Skip to content

Fix airspeed calculation under wind influence by wind triangle #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: gz-sim9
Choose a base branch
from
Open

Fix airspeed calculation under wind influence by wind triangle #2844

wants to merge 6 commits into from

Conversation

TigerWuu
Copy link
Contributor

@TigerWuu TigerWuu commented Apr 2, 2025 •
edited
Loading

🦟 Bug fix

Result from the discussion in PX4/PX4-Autopilot#24452
Depends on

Summary

Refer to windEffect plugin, the airspeed plugin obtains wind information through ECM and transmits it to the airspeed sensor to calculate true airspeed considering wind influence, which is by calling SetWindVelocity function.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Apr 2, 2025
@TigerWuu TigerWuu marked this pull request as ready for review April 2, 2025 16:38
@TigerWuu TigerWuu requested a review from mjcarroll as a code owner April 2, 2025 16:38
ahcorde
ahcorde requested changes Apr 2, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 2, 2025
@iche033 iche033 added the needs upstream release Blocked by a release of an upstream library label Apr 10, 2025
iche033
iche033 reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me. This needs a gz-sensors9 release for CI to be green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 left review comments

@ahcorde ahcorde ahcorde requested changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic needs upstream release Blocked by a release of an upstream library
Projects
Core development
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TigerWuu @ahcorde @iche033