gz-sim-model: workaround cli11 bug#2921
Merged
Merged
Conversation
There is a bug in cli11 for versions >= 2.2 and < 2.5. This works around the bug for the affected versions. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
commented
May 27, 2025
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
32efeb2 to
aacf1db
Compare
iche033
approved these changes
May 29, 2025
iche033
left a comment
Contributor
There was a problem hiding this comment.
I haven't seen the UNIT_SystemLoader_TEST failures in the gz_sim-pr-cnlwin build before but they look unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2918
Summary
There is a bug in cli11 for versions >= 2.2 and < 2.5. This works around the bug for the affected versions, similar to the approached identified by @j-rivero in #2910 (comment).
To test, I will run a colcon CI job on 24.04 (which has cli11 version 2.4.1) with vending of cli11 disabled by reverting gazebosim/gz-utils#178.
Test summary
Full console output
Details
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.