Skip to content

Moves libdwarf, libdw and binutils in as dependencies #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented May 28, 2025

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #

Summary

This is necessary to get stack-traces properly formatted in our CI when developing. It can be useful for us to track why tests are flaky.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@arjo129 arjo129 requested a review from j-rivero May 28, 2025 03:44
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label May 28, 2025
This is nessecary to get stacktraces properly formatted in our CI when
developing.

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 force-pushed the arjo/feat/add_dwarf_dep branch from cf9ddf6 to 602d116 Compare May 28, 2025 03:46
@arjo129 arjo129 marked this pull request as ready for review June 2, 2025 22:52
@arjo129 arjo129 requested a review from mjcarroll as a code owner June 2, 2025 22:52
@j-rivero j-rivero requested a review from jennuine as a code owner June 4, 2025 11:18
@j-rivero
Copy link
Contributor

j-rivero commented Jun 4, 2025

Trying to reproduce the error locally I found a2098ad. Seems not to be the same error reported in Jenkins although affecting the same test. Let's see what the new CI brings. The test passes on my computer now.

Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to reproduce the error locally I found a2098ad. Seems not to be the same error reported in Jenkins although affecting the same test. Let's see what the new CI brings. The test passes on my computer now.

Seems to work. Running an update on the CI to check flakiness a little bit and good to go.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jun 5, 2025
@j-rivero
Copy link
Contributor

j-rivero commented Jun 5, 2025

Failure is coming from a timeout in a flaky test. Merging.

@j-rivero j-rivero merged commit 53c9369 into main Jun 5, 2025
8 of 9 checks passed
@j-rivero j-rivero deleted the arjo/feat/add_dwarf_dep branch June 5, 2025 14:32
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jun 5, 2025
@j-rivero
Copy link
Contributor

j-rivero commented Jun 6, 2025

@Mergifyio backport gz-sim8

Copy link
Contributor

mergify bot commented Jun 6, 2025

backport gz-sim8

✅ Backports have been created

@scpeters
Copy link
Member

scpeters commented Jun 6, 2025

https://github.com/Mergifyio backport gz-sim9

Copy link
Contributor

mergify bot commented Jun 6, 2025

backport gz-sim9

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants