-
Notifications
You must be signed in to change notification settings - Fork 312
Moves libdwarf, libdw and binutils in as dependencies #2927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is nessecary to get stacktraces properly formatted in our CI when developing. Signed-off-by: Arjo Chakravarty <[email protected]>
cf9ddf6
to
602d116
Compare
Signed-off-by: Jose Luis Rivero <[email protected]>
Trying to reproduce the error locally I found a2098ad. Seems not to be the same error reported in Jenkins although affecting the same test. Let's see what the new CI brings. The test passes on my computer now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to reproduce the error locally I found a2098ad. Seems not to be the same error reported in Jenkins although affecting the same test. Let's see what the new CI brings. The test passes on my computer now.
Seems to work. Running an update on the CI to check flakiness a little bit and good to go.
Failure is coming from a timeout in a flaky test. Merging. |
@Mergifyio backport gz-sim8 |
✅ Backports have been created
|
https://github.com/Mergifyio backport gz-sim9 |
✅ Backports have been created
|
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Closes #
Summary
This is necessary to get stack-traces properly formatted in our CI when developing. It can be useful for us to track why tests are flaky.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.