Fix crash when setting debug visualization mode while gi is disabled (backport #3059)
#3071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ahcorde
approved these changes
Sep 8, 2025
Contributor
|
@Mergifyio rebase |
Contributor
Author
✅ Branch has been successfully rebased |
azeey
force-pushed
the
mergify/bp/gz-sim10/pr-3059
branch
from
54bd22c to
8bd7dc0
Compare
…3059) Signed-off-by: momo <[email protected]> Co-authored-by: Ian Chen <[email protected]> (cherry picked from commit 019e38c)
iche033
force-pushed
the
mergify/bp/gz-sim10/pr-3059
branch
from
8bd7dc0 to
cd5bf8f
Compare
iche033
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3058
Summary
When attempting to set the debug visualization mode, the code now checks if
giis enabled. Ifgiis disabled, it logs an error and always sets the debug visualization mode toNoneto avoid a crash.Setting a debug visualization mode while
giis disabled can cause a crash due to invalid or released resources. This change ensures safety by forcing the mode to None whengiis not active.Checklist
codecheckpassed (See contributing)This is an automatic backport of pull request #3059 done by [Mergify](https://mergify.com).