Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 2, 2025

🦟 Bug fix

Fixes #3202

Summary

As the switch are using dwarf_tags to handle the case, I think it could dissable the compilation -Wno-switch-default as it was already evaluating the cases, so no need of a deefault clause

To replicate this behaviour follow this steps:

  1. Go to https://build.osrfoundation.org/job/gz_sim-ci-gz-sim8-jammy-amd64 or https://build.osrfoundation.org/job/gz_sim-ci-gz-sim8-noble-amd64
  2. Build the job
  3. See the gcc warning

Checklist

@mergify mergify bot requested a review from arjo129 as a code owner December 2, 2025 14:13
@mergify mergify bot added the conflicts label Dec 2, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Dec 2, 2025

Cherry-pick of 5318644 has failed:

On branch mergify/bp/gz-sim9/pr-3203
Your branch is up to date with 'origin/gz-sim9'.

You are currently cherry-picking commit 53186440.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   test/CMakeLists.txt

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/backward_vendor/backward-cpp/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: miguelgonrod <[email protected]>
(cherry picked from commit 5318644)
@scpeters scpeters force-pushed the mergify/bp/gz-sim9/pr-3203 branch from 4118e4f to 1db1c8a Compare December 4, 2025 05:21
@scpeters scpeters removed the conflicts label Dec 4, 2025
@scpeters
Copy link
Member

scpeters commented Dec 4, 2025

Cherry-pick of 5318644 has failed:

I resolved the conflicts manually, amended and force-pushed to 1db1c8a

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Dec 4, 2025
@arjo129 arjo129 merged commit 1dcbdf7 into gz-sim9 Dec 4, 2025
14 of 15 checks passed
@arjo129 arjo129 deleted the mergify/bp/gz-sim9/pr-3203 branch December 4, 2025 10:13
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants