Fix DART crash caused by non-positive definite spatial inertia #3247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3246
Summary
Previously, if a model contained invalid inertial properties (specifically, a non-positive definite spatial inertia matrix, often caused by incorrect
fluid_added_masscoefficients), the invalid matrix was passed directly to DART, triggering an assertion failure(Assertion !math::isNan(partialAcceleration) failed)and causing the server to abort.This patch adds a validation step in
Physics.cc(both in CreateModelEntities and CreateLinkEntities) usingEigen::LLTdecomposition to ensure the spatial inertia matrix is positive definite before passing it to the physics engine.Checklist
codecheckpassed (See contributing)