Prevent publishing empty messages in pose publisher (backport #3262)#3264
Merged
Prevent publishing empty messages in pose publisher (backport #3262)#3264
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 80246e0)
9 tasks
ahcorde
approved these changes
Jan 12, 2026
iche033
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Add a check to make sure we don't publish pose messages if it's empty, otherwise you get a bunch of empty msgs.
To test:
Add the pose publisher system to your favorite static model., e.g. edit
shapes.dfand add the following system to theground_planemodel:Run sim:
Now echo the
/model/ground_plane/posetopic to see that no messages should be published. Before this fix, there'll be a lot of empty messages (empty lines)Echo the
pose_statictopic to make sure data are published:Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #3262 done by [Mergify](https://mergify.com).