Improve performance of ECM::Entit(y|ies)ByComponents and ECM::ChildrenByComponents (backport #3375)#3526
Open
mergify[bot] wants to merge 1 commit intogz-sim8from
Open
Improve performance of ECM::Entit(y|ies)ByComponents and ECM::ChildrenByComponents (backport #3375)#3526mergify[bot] wants to merge 1 commit intogz-sim8from
ECM::Entit(y|ies)ByComponents and ECM::ChildrenByComponents (backport #3375)#3526mergify[bot] wants to merge 1 commit intogz-sim8from
Conversation
…drenByComponents` (#3375) This is a follow up optimization from Follow up from #3362 where components are retrieved from the view instead of via `ECM::Component<T>`, which is expensive. Since the view caches the components, access to these components has the same performance characteristics as `ECM::Each`. Generated-By: Gemini 3.0 Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Co-authored-by: Luca Della Vedova <lucadv@intrinsic.ai> (cherry picked from commit a5b6bca) # Conflicts: # include/gz/sim/detail/EntityComponentManager.hh
Contributor
Author
|
Cherry-pick of a5b6bca has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
This is a follow up optimization from Follow up from #3362 where components are retrieved from the view instead of via
ECM::Component<T>, which is expensive. Since the view caches the components, access to these components has the same performance characteristics asECM::Each.Checklist
codecheckpassed (See contributing)Generated-By: Gemini 3.0
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.
This is an automatic backport of pull request #3375 done by Mergify.