Fix crash for invalid index in force torque GUI plugin (backport #3601)#3632
Open
mergify[bot] wants to merge 1 commit into
Open
Fix crash for invalid index in force torque GUI plugin (backport #3601)#3632mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Originally found by @iche033 in intrinsic-dev/aic#553, it seems that due to a race condition sometimes the linkIndex is set to an uninitialized value (-1). We then try to do an array access with that index and crash. Just added a boundary check so we don't do that until the next call to the Update function. Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Co-authored-by: Arjo Chakravarty <arjoc@intrinsic.ai> (cherry picked from commit de5e2a2) # Conflicts: # src/gui/plugins/apply_force_torque/ApplyForceTorque.cc
Contributor
Author
|
Cherry-pick of de5e2a2 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes crash when selecting models and the ApplyForceTorque plugin is loaded.
Summary
Originally found by @iche033 in intrinsic-dev/aic#553, it seems that due to a race condition sometimes the
linkIndexis set to an uninitialized value (-1). We then try to do an array access with that index and crash.Just added a boundary check so we don't do that until the next call to the
Updatefunction.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #3601 done by Mergify.