[BUG] Honor MoleculeLoader ignore_duplicates when exporting sequences#313
Closed
officialasishkumar wants to merge 1 commit into
Closed
[BUG] Honor MoleculeLoader ignore_duplicates when exporting sequences#313officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #312.
What does this implement/fix? Explain your changes.
This fixes
MoleculeLoader.to_df_seq()so the documentedignore_duplicatesflag is actually honored. The loader now builds the sequence DataFrame first, drops duplicate sequence rows while keeping the first occurrence when the flag is enabled, and then applies any optional column renaming.What should a reviewer concentrate their feedback on?
The duplicate-removal behavior in
MoleculeLoader.to_df_seq()and whether preserving the first indexed occurrence matches the intended contract for sequence exports.Did you add any tests for the change?
Yes. I added a regression test that reproduces the bug with duplicate PDB inputs and verifies that:
ignore_duplicates=TrueAny other comments?
Validation run locally:
.venv/bin/pytest pyaptamer -p no:warnings.venv/bin/pre-commit run --files pyaptamer/data/loader.py pyaptamer/data/tests/test_loader.pyPR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files