[ENH] Add minimal AptaMCTS pipeline (MCTS-based aptamer recommendation)#525
[ENH] Add minimal AptaMCTS pipeline (MCTS-based aptamer recommendation)#525kris70lesgo wants to merge 3 commits into
Conversation
NennoMP
left a comment
There was a problem hiding this comment.
The issue specifically mentions to look at AptaNet interface (quoting myself I would expect a very similar interface to that of AptaNet) rather than AptaTrans. Indeed, I don't see methods such as fit or predict_proba. AptaTrans was mentioned purely in terms of compatibility w.r.t. MCTS.
| from pyaptamer.utils._aptamcts_utils import pairs_to_features | ||
|
|
||
|
|
||
| class AptaMCTSPipeline: |
There was a problem hiding this comment.
Interface is not in line with AptaNet, please look carefully at the description.
| from pyaptamer.experiments._aptamer import BaseAptamerEval | ||
|
|
||
|
|
||
| class AptamerEvalAptaMCTS(BaseAptamerEval): |
There was a problem hiding this comment.
Once the interface is similar to AptaNet as specified in the issue, this could easily be one single class that works for both AptaMCTS and AptaNet, since we expect a very similar interface.
574d814 to
4ab7bcd
Compare
db039ff to
303a07f
Compare
|
@NennoMP Thanks for the review
Would appreciate another review |
|
I don't see a module in line with what |
Reference Issues/PRs
Fixes #21
What does this implement/fix? Explain your changes.
This PR adds a minimal implementation of AptaMCTS, an aptamer recommendation pipeline that combines a scoring model with the existing Monte Carlo Tree Search (MCTS) algorithm.
Key additions:
predict()andrecommend()methodsevaluate()utils: placeholder iCTF-style encoding (pairs_to_features)The pipeline follows the AptaTrans-style design:
experiment.evaluate()onlypredict_proba()What should a reviewer concentrate their feedback on?
predict,recommend)recommend()(candidate, sequence, score)utilsDid you add any tests for the change?
Yes.
Added focused tests covering:
predict()returns correct type (np.float64) and usespredict_probarecommend()output structure and MCTS integrationAptamerEvalAptaMCTS.evaluate()correctnessAll tests pass successfully.
Any other comments?
PR checklist