[BUG/ENH] Fix skbase contract, expose AptaNet hyperparameters, add sktime benchmark integration (#568, #169, #125)#601
Closed
pranavchoudhary-tech wants to merge 9 commits into
Closed
Conversation
…zer, device, weight_decay (gc-os-ai#169)
…ator compatibility (gc-os-ai#125)
6413d28 to
a5bda46
Compare
a5bda46 to
fae2f67
Compare
| alpha=0.9, | ||
| eps=1e-08, | ||
| weight_decay=0.0, | ||
| n_estimators=300, |
Author
There was a problem hiding this comment.
I chose n_estimators=300 as the default here because it provided the best balance between accuracy and training speed during my local testing.
added 4 commits
May 2, 2026 16:25
Author
Author
Collaborator
|
Hi, Closing this as it has multiple issues in a single PR which increases load on maintainers for review, please make sure to open separate PR for each of these issue, if there is no previously opened PR on the issues. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues
Fixes #568 Fixes #169 Fixes #125
What does this implement/fix?
This PR resolves one bug and two enhancements to improve
pyaptamer's reliability, customizability, and integration with thescikit-learn/sktimeecosystem:classmethod(skbase contract) [BUG] GreedyEncoder.get_test_params should be aclassmethod(skbase contract) #568):GreedyEncoder.get_test_paramswas missing the@classmethoddecorator, causingTypeErrors in automated testing pipelines. Added the decorator and updated the method signature to comply withskbasestandards.AptaNetClassifierandAptaNetRegressorhad critical hyperparameters hardcoded with no way to customize them. Exposedn_estimators,max_depth,optimizer,device, andweight_decayas constructor parameters on both classes. All defaults match previous values for full backward compatibility.sktimehas required benchmark functionality to assist with benchmark [ENH] MakeAptaNetregression-friendly forbenchmarking#115 [ENH] ensuresktimehas required benchmark functionality to assist with benchmark #115 #125): Added areturn_raw=Falseparameter toBenchmarking.run(). WhenTrue, it returns a tuple(summary, raw)whererawis a per-fold DataFrame with a three-level MultiIndex(estimator, metric, fold), directly compatible withsktime'sEvaluatorclass for Friedman tests and Critical Difference diagrams. Also added araw_results_attribute populated after everyrun()call.Checklist
💡 Design Decisions & Notes
MaskedDatasetlogic, but I found that adding the explicitval > 0check was the cleanest and most efficient way to avoid the padding bias I was seeing during local testing.