[BUG] Fix encode_rna docstring terminology and add return_type validation#617
Open
Ishiezz wants to merge 2 commits into
Open
[BUG] Fix encode_rna docstring terminology and add return_type validation#617Ishiezz wants to merge 2 commits into
Ishiezz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #616
What does this implement/fix?
Two bugs fixed in
pyaptamer/utils/_rna.pyin theencode_rnafunction:Bug 1 — Wrong docstring terminology (copy-paste from protein encoder)
The function handles RNA sequences but its docstring incorrectly referenced
"protein sequences", "amino acid patterns", and had a typo ("trunacted"):
word_max_lendescription: "amino acid patterns" → "RNA patterns"Bug 2 — Invalid
return_typesilently returns tensor instead of raising ValueErrorBefore this fix:
After this fix:
This is now consistent with how
rna2vechandles invalidsequence_type.Did you add any tests?
Yes. Added
test_encode_rna_invalid_return_typeto cover Bug 2.All 20 tests in
pyaptamer/utils/tests/test_rna.pypass.PR checklist
[BUG]