[ENH] Add augment_complement for RNA/DNA reverse complement augmentation#623
Closed
Vaishnav88sk wants to merge 1 commit into
Closed
[ENH] Add augment_complement for RNA/DNA reverse complement augmentation#623Vaishnav88sk wants to merge 1 commit into
Vaishnav88sk wants to merge 1 commit into
Conversation
Add augment_complement() to _augment.py that generates biologically meaningful reverse complement sequences (A↔U for RNA, A↔T for DNA, C↔G). Supports both RNA and DNA via molecule_type parameter, preserves case, and follows the same API pattern as augment_reverse. Includes 8 new tests covering RNA/DNA complements, case handling, round-trip validation, multiple arrays, and error handling.
Collaborator
|
Please have discussion before opening a PR for an issue, or if you create one please keep it draft PR until discussion around it has happened. |
Contributor
Author
|
Hi @siddharth7113, my apologies! I got a bit too eager with the implementation since I already had it passing locally. I completely respect the workflow, I will convert this to a draft PR while we finalize the architectural discussion over in issue #618. Thanks for guiding me on the project conventions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #618
What does this implement/fix? Explain your changes.
Adds
augment_complementtoutils/_augment.pywhich computes biologically meaningful reverse complement sequences.What should a reviewer concentrate their feedback on?
augment_reverseAPI.Did you add any tests for the change?
Yes, added 8 tests in
test_augment.pycovering case handling, molecule types, and round-trip validation.Any other comments?
N/A
PR checklist