-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Move trace propagation to its own class #6337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tests/SentryTests/Integrations/Performance/Network/SentryNetworkTrackerTests.swift
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6337 +/- ##
=============================================
+ Coverage 86.765% 86.814% +0.048%
=============================================
Files 438 439 +1
Lines 37311 37313 +2
Branches 17421 17426 +5
=============================================
+ Hits 32373 32393 +20
+ Misses 4893 4874 -19
- Partials 45 46 +1
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5196f0d | 1213.35 ms | 1231.37 ms | 18.02 ms |
be6a4ee | 1226.33 ms | 1249.77 ms | 23.44 ms |
5aa3ce5 | 1222.78 ms | 1245.39 ms | 22.61 ms |
449d185 | 1216.31 ms | 1251.94 ms | 35.62 ms |
8203ac0 | 1235.59 ms | 1256.02 ms | 20.43 ms |
d23a1b1 | 1218.94 ms | 1239.53 ms | 20.60 ms |
09471ff | 1239.98 ms | 1256.65 ms | 16.67 ms |
acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
1936411 | 1231.51 ms | 1253.27 ms | 21.76 ms |
588dd7c | 1235.11 ms | 1241.76 ms | 6.65 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5196f0d | 23.75 KiB | 876.93 KiB | 853.19 KiB |
be6a4ee | 23.75 KiB | 913.14 KiB | 889.39 KiB |
5aa3ce5 | 23.75 KiB | 904.54 KiB | 880.79 KiB |
449d185 | 23.75 KiB | 980.81 KiB | 957.06 KiB |
8203ac0 | 23.75 KiB | 959.44 KiB | 935.69 KiB |
d23a1b1 | 23.75 KiB | 913.64 KiB | 889.88 KiB |
09471ff | 23.75 KiB | 990.16 KiB | 966.41 KiB |
acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
1936411 | 23.74 KiB | 913.39 KiB | 889.64 KiB |
588dd7c | 23.75 KiB | 938.33 KiB | 914.58 KiB |
Previous results on branch: ref/extract-trace-propagation
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a712a29 | 1220.81 ms | 1253.53 ms | 32.72 ms |
8f3a9d6 | 1224.49 ms | 1254.50 ms | 30.01 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a712a29 | 23.74 KiB | 995.46 KiB | 971.72 KiB |
8f3a9d6 | 23.75 KiB | 989.91 KiB | 966.17 KiB |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Extract the trace propagation logic into its own class, so its easier to test and maintain.
c169cf5
to
2c609bb
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Extract the trace propagation logic into its own class, so it's easier to test and maintain.
Prep for #6017.
#skip-changelog
Closes #6339