Skip to content

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 3, 2025

Extract the trace propagation logic into its own class, so it's easier to test and maintain.

Prep for #6017.

#skip-changelog

Closes #6339

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 81.42857% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.814%. Comparing base (fa9a4bb) to head (c169cf5).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryTracePropagation.m 79.032% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6337       +/-   ##
=============================================
+ Coverage   86.765%   86.814%   +0.048%     
=============================================
  Files          438       439        +1     
  Lines        37311     37313        +2     
  Branches     17421     17426        +5     
=============================================
+ Hits         32373     32393       +20     
+ Misses        4893      4874       -19     
- Partials        45        46        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryNetworkTracker.m 99.729% <100.000%> (+2.992%) ⬆️
Sources/Sentry/SentryTracePropagation.m 79.032% <79.032%> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9a4bb...c169cf5. Read the comment docs.

Copy link
Contributor

github-actions bot commented Oct 3, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.65 ms 1266.21 ms 35.56 ms
Size 23.75 KiB 986.81 KiB 963.06 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5196f0d 1213.35 ms 1231.37 ms 18.02 ms
be6a4ee 1226.33 ms 1249.77 ms 23.44 ms
5aa3ce5 1222.78 ms 1245.39 ms 22.61 ms
449d185 1216.31 ms 1251.94 ms 35.62 ms
8203ac0 1235.59 ms 1256.02 ms 20.43 ms
d23a1b1 1218.94 ms 1239.53 ms 20.60 ms
09471ff 1239.98 ms 1256.65 ms 16.67 ms
acac774 1217.76 ms 1253.29 ms 35.52 ms
1936411 1231.51 ms 1253.27 ms 21.76 ms
588dd7c 1235.11 ms 1241.76 ms 6.65 ms

App size

Revision Plain With Sentry Diff
5196f0d 23.75 KiB 876.93 KiB 853.19 KiB
be6a4ee 23.75 KiB 913.14 KiB 889.39 KiB
5aa3ce5 23.75 KiB 904.54 KiB 880.79 KiB
449d185 23.75 KiB 980.81 KiB 957.06 KiB
8203ac0 23.75 KiB 959.44 KiB 935.69 KiB
d23a1b1 23.75 KiB 913.64 KiB 889.88 KiB
09471ff 23.75 KiB 990.16 KiB 966.41 KiB
acac774 23.75 KiB 866.51 KiB 842.76 KiB
1936411 23.74 KiB 913.39 KiB 889.64 KiB
588dd7c 23.75 KiB 938.33 KiB 914.58 KiB

Previous results on branch: ref/extract-trace-propagation

Startup times

Revision Plain With Sentry Diff
a712a29 1220.81 ms 1253.53 ms 32.72 ms
8f3a9d6 1224.49 ms 1254.50 ms 30.01 ms

App size

Revision Plain With Sentry Diff
a712a29 23.74 KiB 995.46 KiB 971.72 KiB
8f3a9d6 23.75 KiB 989.91 KiB 966.17 KiB

cursor[bot]

This comment was marked as outdated.

Copy link
Member Author

philipphofmann commented Oct 6, 2025

Extract the trace propagation logic into its own class, so its easier to
test and maintain.
@philipphofmann philipphofmann force-pushed the ref/extract-trace-propagation branch from c169cf5 to 2c609bb Compare October 8, 2025 02:50
Copy link
Contributor

github-actions bot commented Oct 8, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

@philipphofmann philipphofmann merged commit 687ccf6 into main Oct 8, 2025
194 of 198 checks passed
@philipphofmann philipphofmann deleted the ref/extract-trace-propagation branch October 8, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Move trace propagation to its own class

3 participants