-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Remove SentrySDK from trace propagation class #6354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Remove SentrySDK from trace propagation class #6354
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6354 +/- ##
=============================================
+ Coverage 86.822% 86.844% +0.022%
=============================================
Files 439 439
Lines 37313 37316 +3
Branches 17424 17426 +2
=============================================
+ Hits 32396 32407 +11
+ Misses 4873 4865 -8
Partials 44 44
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
51b7dd3 | 1235.06 ms | 1258.21 ms | 23.15 ms |
6cb4338 | 1238.47 ms | 1256.96 ms | 18.49 ms |
397b9c9 | 1230.23 ms | 1249.29 ms | 19.06 ms |
7273bf4 | 1202.42 ms | 1227.62 ms | 25.21 ms |
9a32d52 | 1215.69 ms | 1236.85 ms | 21.16 ms |
d06a4db | 1233.20 ms | 1243.18 ms | 9.98 ms |
6e99155 | 1223.96 ms | 1249.25 ms | 25.29 ms |
4267263 | 1233.13 ms | 1266.13 ms | 33.00 ms |
d637379 | 1226.43 ms | 1250.77 ms | 24.34 ms |
ed85746 | 1231.79 ms | 1248.55 ms | 16.75 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
51b7dd3 | 23.75 KiB | 913.26 KiB | 889.52 KiB |
6cb4338 | 23.75 KiB | 913.63 KiB | 889.88 KiB |
397b9c9 | 23.75 KiB | 959.44 KiB | 935.70 KiB |
7273bf4 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
9a32d52 | 23.75 KiB | 981.29 KiB | 957.54 KiB |
d06a4db | 23.75 KiB | 913.18 KiB | 889.43 KiB |
6e99155 | 23.75 KiB | 963.18 KiB | 939.43 KiB |
4267263 | 23.75 KiB | 988.03 KiB | 964.28 KiB |
d637379 | 23.75 KiB | 855.38 KiB | 831.63 KiB |
ed85746 | 23.75 KiB | 920.83 KiB | 897.08 KiB |
Previous results on branch: ref_remove_sentrysdk_from_trace_propagation_class
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3b2a042 | 1218.55 ms | 1249.25 ms | 30.70 ms |
9176c69 | 1212.79 ms | 1251.96 ms | 39.17 ms |
e70fc88 | 1211.22 ms | 1246.09 ms | 34.87 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3b2a042 | 23.75 KiB | 986.73 KiB | 962.98 KiB |
9176c69 | 23.75 KiB | 986.73 KiB | 962.98 KiB |
e70fc88 | 23.75 KiB | 989.92 KiB | 966.18 KiB |
3f3c1fe
to
750199d
Compare
9811ec4
to
23935a2
Compare
23935a2
to
38d2b5f
Compare
750199d
to
8f2d7b7
Compare
8f2d7b7
to
a48560a
Compare
38d2b5f
to
41c0aa8
Compare
a48560a
to
a3dc1e0
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
📜 Description
Refactored
SentryTracePropagation
to accepttracePropagationTargets
as a parameter instead of directly accessing it fromSentrySDKInternal.options
. This removes the dependency onSentrySDK+Private.h
in the trace propagation module.💡 Motivation and Context
This change improves the architecture by reducing direct dependencies on the SDK internals. By passing the
tracePropagationTargets
as a parameter, the trace propagation functionality becomes more modular and easier to test.#skip-changelog
Closes #6355