Skip to content

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 6, 2025

📜 Description

Refactored trace propagation tests by moving them from SentryNetworkTrackerTests to a dedicated SentryTracePropagationTests file. The tests were also improved with better organization, more descriptive test names, and clearer arrange-act-assert patterns.

💡 Motivation and Context

This change improves test organization by separating trace propagation tests into their own file, making the codebase more maintainable. The refactored tests are now more readable with better naming conventions and structure.

💚 How did you test it?

Ran the existing tests to ensure they still pass after being moved and refactored.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

Closes #6353

Copy link
Member Author

philipphofmann commented Oct 6, 2025

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.792%. Comparing base (687ccf6) to head (38d2b5f).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6352       +/-   ##
=============================================
- Coverage   86.830%   86.792%   -0.038%     
=============================================
  Files          439       439               
  Lines        37313     37313               
  Branches     17427     17426        -1     
=============================================
- Hits         32399     32385       -14     
- Misses        4870      4883       +13     
- Partials        44        45        +1     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687ccf6...38d2b5f. Read the comment docs.

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.86 ms 1233.18 ms 17.32 ms
Size 23.75 KiB 986.79 KiB 963.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5196f0d 1213.35 ms 1231.37 ms 18.02 ms
be6a4ee 1226.33 ms 1249.77 ms 23.44 ms
5aa3ce5 1222.78 ms 1245.39 ms 22.61 ms
449d185 1216.31 ms 1251.94 ms 35.62 ms
8203ac0 1235.59 ms 1256.02 ms 20.43 ms
d23a1b1 1218.94 ms 1239.53 ms 20.60 ms
09471ff 1239.98 ms 1256.65 ms 16.67 ms
acac774 1217.76 ms 1253.29 ms 35.52 ms
1936411 1231.51 ms 1253.27 ms 21.76 ms
588dd7c 1235.11 ms 1241.76 ms 6.65 ms

App size

Revision Plain With Sentry Diff
5196f0d 23.75 KiB 876.93 KiB 853.19 KiB
be6a4ee 23.75 KiB 913.14 KiB 889.39 KiB
5aa3ce5 23.75 KiB 904.54 KiB 880.79 KiB
449d185 23.75 KiB 980.81 KiB 957.06 KiB
8203ac0 23.75 KiB 959.44 KiB 935.69 KiB
d23a1b1 23.75 KiB 913.64 KiB 889.88 KiB
09471ff 23.75 KiB 990.16 KiB 966.41 KiB
acac774 23.75 KiB 866.51 KiB 842.76 KiB
1936411 23.74 KiB 913.39 KiB 889.64 KiB
588dd7c 23.75 KiB 938.33 KiB 914.58 KiB

Previous results on branch: test_extract_istargettests_to_own_test_class

Startup times

Revision Plain With Sentry Diff
1482bc8 1221.63 ms 1254.50 ms 32.87 ms
c61d576 1234.26 ms 1265.79 ms 31.53 ms

App size

Revision Plain With Sentry Diff
1482bc8 23.75 KiB 989.90 KiB 966.16 KiB
c61d576 23.75 KiB 986.80 KiB 963.05 KiB

@philipphofmann philipphofmann force-pushed the ref/extract-trace-propagation branch from c169cf5 to 2c609bb Compare October 8, 2025 02:50
@philipphofmann philipphofmann force-pushed the test_extract_istargettests_to_own_test_class branch from 9811ec4 to 23935a2 Compare October 8, 2025 02:50
Base automatically changed from ref/extract-trace-propagation to main October 8, 2025 04:58
@philipphofmann philipphofmann force-pushed the test_extract_istargettests_to_own_test_class branch from 23935a2 to 38d2b5f Compare October 8, 2025 05:10
@philipphofmann philipphofmann merged commit 41c0aa8 into main Oct 8, 2025
192 of 198 checks passed
@philipphofmann philipphofmann deleted the test_extract_istargettests_to_own_test_class branch October 8, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: Extract isTargetTests to own test class

2 participants