gtk: implement custom audio bell #5326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just want to note I'm going to not review this pending further discussion (I know there's a discussion open). One thing I noticed right away though if you care is this uses the old |
jcollie
force-pushed
the
gtk-bell-2
branch
3 times, most recently
from
b4c992a to
76a0193
Compare
jcollie
force-pushed
the
gtk-bell-2
branch
2 times, most recently
from
7d8f74e to
aaacbb6
Compare
jcollie
force-pushed
the
gtk-bell-2
branch
3 times, most recently
from
32b8873 to
2b229af
Compare
jcollie
force-pushed
the
gtk-bell-2
branch
2 times, most recently
from
b24024f to
c1150de
Compare
|
Gave the PR and test and the bell works perfectly on NixOS 25.05 unstable (built from source) Edit: Also I forgot to mention I was using KDE Plasma 6.3 on my system (with the Ocean sound theme) when I was testing the PR |
NovaViper
approved these changes
Mar 3, 2025
tristan957
reviewed
Mar 3, 2025
00-kat
approved these changes
Mar 3, 2025
pluiedev
requested changes
Mar 4, 2025
jcollie
force-pushed
the
gtk-bell-2
branch
4 times, most recently
from
800eae5 to
995ac4a
Compare
|
Converted to draft until #6622 is merged. |
jcollie
force-pushed
the
gtk-bell-2
branch
2 times, most recently
from
c1698d6 to
081ee20
Compare
Merged
mitchellh
added a commit
that referenced
this pull request
Apr 14, 2025
This PR implements a more lightweight alternative to #5326 that contains features that I personally think Just Make Sense for the bell. No configs, no GStreamer stuff, just sane defaults to get us started.
jcollie
force-pushed
the
gtk-bell-2
branch
2 times, most recently
from
49b9baa to
d32f8ec
Compare
tristan957
approved these changes
Apr 15, 2025
Co-authored-by: Tristan Partin <[email protected]>
pluiedev
requested changes
Apr 16, 2025
| std.debug.assert(std.fs.path.isAbsolute(pathname)); | ||
| const media_file = gtk.MediaFile.newForFilename(pathname); | ||
|
|
||
| if (!optional) { |
There was a problem hiding this comment.
Nit: honestly if (required) { would make more sense and then you could just flip the boolean values above
Co-authored-by: Leah Amelia Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2710
Adds support for custom audio bell notifications.