Change NodeOneShot fading to uses self delta instead of input delta
#101792
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
commented
Jan 19, 2025
| </member> | ||
| <member name="fadeout_curve" type="Curve" setter="set_fadeout_curve" getter="get_fadeout_curve"> | ||
| Determines how cross-fading between animations is eased. If empty, the transition will be linear. Should be a unit [Curve]. | ||
| </member> | ||
| <member name="fadeout_time" type="float" setter="set_fadeout_time" getter="get_fadeout_time" default="0.0"> | ||
| The fade-out duration. For example, setting this to [code]1.0[/code] for a 5 second length animation will produce a cross-fade that starts at 4 second and ends at 5 second during the animation. | ||
| [b]Note:[/b] [AnimationNodeOneShot] transitions the current state after the end of the fading. When [AnimationNodeOutput] is considered as the most upstream, so the [member fadeout_time] is scaled depending on the downstream delta. For example, if this value is set to [code]1.0[/code] and an [AnimationNodeTimeScale] with a value of [code]2.0[/code] is chained downstream, the actual processing time will be 0.5 second. |
There was a problem hiding this comment.
This deleted line is exactly what explains the change in behavior due to this PR compatibility breakdown. There is a migration path that multiplies the downstream TimeScale to the fading time of the NodeOneShot.
TokageItLab
force-pushed
the
oneshot-scale
branch
from
02068c2 to
0ab8680
Compare
AThousandShips
changed the title
NodeOneShot fading so that it does not depend on input delta
TokageItLab
changed the title
NodeOneShot fading so that it does not depend on input deltaNodeOneShot fading to uses self delta instead of input delta
TokageItLab
force-pushed
the
oneshot-scale
branch
from
0ab8680 to
ba4679b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_self_delta_to_fadeto NodeOneShot to fade finished animation #101788Predict the time scale from the delta difference so that the fading time does not depend on the input AnimationNode's delta.
This breaks compatibility a bit because it changes the behavior of the existing fading time scaled by the downstream time scale. However, since the scaling is specific to NodeOneShot, this should bring it closer to the behavior of other AnimationNodes.
It is possible that a strange state may be produced if the timescale is changed during a fade, but since NodeTransiton and StateMachine should have the same problem, I judge that it is not a problem. The case where the timescale is changed during a transition in AtEnd with a fade is quite niche, IMO.
The problem of the fade time and end time being out of sync as in #87009, should no longer occur, but the fade duration will change, as explained below.