-
-
Notifications
You must be signed in to change notification settings - Fork 23.9k
Use separate_debug_symbols to control generation of the separate Android debug symbols file
#105671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use separate_debug_symbols to control generation of the separate Android debug symbols file
#105671
Conversation
Repiteo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unified naming scheme is preferable
|
I think I want to preserve the default gradle behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I'd be fine either way (with this PR or keeping gradle_do_not_strip), but with maybe a slight preference for standardization among platforms.
|
The more I think about this, the more I think this PR is the way to go:
|
…droid debug symbols file
58f3b0b to
ccf6165
Compare
@dsnopek This is a good argument to keep consistency across the platforms, so I'm good for this PR to go as is!
@syntaxerror247 The added logic should keep the default behavior: The addition of the
|
|
Thanks! |
This addresses feedback from #105605 (comment).
As mentioned in #105605 (comment), I don't have a preference over which parameter to use, so looking for feedback.