- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 23.5k
 
GDExtension: Add system for builtin method compatibility #112290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
52490b0    to
    1b76718      
    Compare
  
    1b76718    to
    d666f67      
    Compare
  
    d666f67    to
    75731f8      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the details here are beyond my expertise, but suffice to say, so long as it works, I'm happy with it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and cases look good to me
Co-authored-by: Aaron Franke <[email protected]>
75731f8    to
    1e12993      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this addition is needed. Code and approach look good to me.
Only caveat I have is I haven't tested it, but since David tested this that's good enough for me.
Up until now, we haven't had any way to register compatibility methods for builtin methods, which has meant that we couldn't change their signature.
This has blocked moving forward on a number of issues, including #79140
This PR adds such a system!
In order to test it, I've also implemented the main change from #79140 in the 2nd commit.
cc @aaronfranke
Supersedes #79140