Add search bar to export options - #119476
Closed
dennisupton wants to merge 1 commit into
Closed
Conversation
Filters export preset options live as the user types, mirroring the pattern used by the EditorSettings dialog.
KoBeWi
previously approved these changes
May 20, 2026
KoBeWi
left a comment
KoBeWi
left a comment
Member
There was a problem hiding this comment.
The implementation looks fine.
Comment on lines
129
to
+132
| duplicate_preset->set_button_icon(presets->get_editor_theme_icon(SNAME("Duplicate"))); | ||
| delete_preset->set_button_icon(presets->get_editor_theme_icon(SNAME("Remove"))); | ||
| patch_add_btn->set_button_icon(get_editor_theme_icon(SNAME("Add"))); | ||
| parameters_search_box->set_right_icon(get_editor_theme_icon(SNAME("Search"))); |
Member
There was a problem hiding this comment.
This code is wrong. Using NOTIFICATION_THEME_CHANGED is enough.
Contributor
|
Is this same as #118898? |
Member
|
That PR seems more complete... |
Contributor
|
Superseded by #118898; thank you for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds a search bar to the top of the export options to filter them, I copied the code from the settings search to make sure it works well.I did it because when exporting to android finding the options took ages. AI was used to make sure i wasn't breaking anything.
What problem(s) does this PR solve?
Finding export options
Testings
I built this and could not find any errors
Image