Skip to content

Add search bar to export options #119476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dennisupton wants to merge 1 commit into from
Closed

Add search bar to export options #119476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions editor/export/project_export.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,14 @@ void ProjectExportDialog::_notification(int p_what) {
duplicate_preset->set_button_icon(presets->get_editor_theme_icon(SNAME("Duplicate")));
delete_preset->set_button_icon(presets->get_editor_theme_icon(SNAME("Remove")));
patch_add_btn->set_button_icon(get_editor_theme_icon(SNAME("Add")));
parameters_search_box->set_right_icon(get_editor_theme_icon(SNAME("Search")));
} break;

case NOTIFICATION_READY: {
duplicate_preset->set_button_icon(presets->get_editor_theme_icon(SNAME("Duplicate")));
delete_preset->set_button_icon(presets->get_editor_theme_icon(SNAME("Remove")));
patch_add_btn->set_button_icon(get_editor_theme_icon(SNAME("Add")));
parameters_search_box->set_right_icon(get_editor_theme_icon(SNAME("Search")));
Comment on lines 129 to +132

@KoBeWi KoBeWi May 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is wrong. Using NOTIFICATION_THEME_CHANGED is enough.

connect(SceneStringName(confirmed), callable_mp(this, &ProjectExportDialog::_export_pck_zip));
_update_export_all();
} break;
Expand Down Expand Up @@ -1650,12 +1652,25 @@ ProjectExportDialog::ProjectExportDialog() {

// Main preset parameters.

VBoxContainer *parameters_vb = memnew(VBoxContainer);
parameters_vb->set_name(TTRC("Options"));
sections->add_child(parameters_vb);

parameters_search_box = memnew(LineEdit);
parameters_search_box->set_placeholder(TTRC("Filter Options"));
parameters_search_box->set_accessibility_name(TTRC("Filter Options"));
parameters_search_box->set_virtual_keyboard_show_on_focus(false);
parameters_search_box->set_clear_button_enabled(true);
parameters_search_box->set_h_size_flags(Control::SIZE_EXPAND_FILL);
parameters_vb->add_child(parameters_search_box);

parameters = memnew(EditorInspector);
parameters->set_name(TTRC("Options"));
parameters->set_mark_unsaved(false);
parameters->set_v_size_flags(Control::SIZE_EXPAND_FILL);
parameters->set_use_doc_hints(true);
sections->add_child(parameters);
parameters->set_use_filter(true);
parameters->register_text_enter(parameters_search_box);
parameters_vb->add_child(parameters);
parameters->connect("property_edited", callable_mp(this, &ProjectExportDialog::_update_parameters));
EditorExport::get_singleton()->connect("export_presets_updated", callable_mp(this, &ProjectExportDialog::_force_update_current_preset_parameters));

Expand Down
1 change: 1 addition & 0 deletions editor/export/project_export.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ class ProjectExportDialog : public ConfirmationDialog {
LineEdit *name = nullptr;
EditorPropertyPath *export_path = nullptr;
EditorInspector *parameters = nullptr;
LineEdit *parameters_search_box = nullptr;
CheckButton *runnable = nullptr;
CheckButton *advanced_options = nullptr;

Expand Down
Loading