Skip to content

Add display/window/screen_id configuration - #23926

Closed
marcelofg55 wants to merge 1 commit into
godotengine:masterfrom
marcelofg55:screen_id
Closed

Add display/window/screen_id configuration#23926
marcelofg55 wants to merge 1 commit into
godotengine:masterfrom
marcelofg55:screen_id

Conversation

@marcelofg55

@marcelofg55 marcelofg55 commented Nov 23, 2018

Copy link
Copy Markdown
Contributor

This new configuration option can be used to start a project on a specific screen.

In combination with #23799 it is now easy to start projects at the last screen used, saving the screen_id with something like:

	var cf = ConfigFile.new()
	cf.set_value("display", "window/screen_id", OS.get_current_screen())
	cf.save("user://override_ps.dat")

Note 1: This also adds a No management option to run/window_placement/rect so that the editor does no management with the window position. Otherwise the display/window/size/screen_id is overridden by the editor (if the project is run inside the editor).

Note 2: By default now Windows, OS X and Linux create the window centered. Previously only Windows and OS X centered the window when it was being created.

@marcelofg55
marcelofg55 requested a review from reduz as a code owner November 23, 2018 13:58
@akien-mga akien-mga added this to the 3.2 milestone Nov 23, 2018
@marcelofg55
marcelofg55 force-pushed the screen_id branch 6 times, most recently from ecebd81 to 591b9a0 Compare November 24, 2018 14:03
@marcelofg55 marcelofg55 changed the title [WIP] Add display/window/size/screen_id configuration Add display/window/size/screen_id configuration Nov 24, 2018
@marcelofg55 marcelofg55 changed the title Add display/window/size/screen_id configuration Add display/window/screen_id configuration Nov 24, 2018
Comment thread editor/editor_settings.cpp Outdated
@mhilbrunner

Copy link
Copy Markdown
Member

Conflicts need to be fixed :)

@akien-mga akien-mga modified the milestones: 3.2, 4.0 Oct 4, 2019
@akien-mga

Copy link
Copy Markdown
Member

Moving to next milestone as it's not in a mergeable state, so it's too late to include in the imminent 3.2.

@aaronfranke

Copy link
Copy Markdown
Member

I believe this PR is no longer relevant thanks to the OS and DisplayServer split. DisplayServer has methods such as window_set_current_screen which should allow what this PR is trying to accomplish. Therefore, I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants