Allow ScrollBar to watch ScrollContainer in tree
#63626
Open
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `ScrollBar` is allowed to watch the `ScrollContainer` if both are in the tree. That is, according to the `orientation` of this `ScrollBar`, the corresponding `ScrollBar` in the `ScrollContainer` is shared with this `ScrollBar`. This patch will make it easy to replace the `ScrollBar` inside the `ScrollContainer` in the editor: 1. Set the corresponding `*_scroll_mode` in `ScrollContainer` to `SCROLL_MODE_SHOW_NEVER`; 2. Add an extra `ScrollBar` and set its `watch_target_path` to the path of the target `ScrollContainer`.
Rindbee
force-pushed
the
allow-ScrollBar-to-watch-ScrollContainer-in-tree
branch
from
16d5a3c to
354722d
Compare
|
Something like this needs a proposal first to see if this is indeed an issue that many need fixing, and if this is indeed the solution that would be the best for the issue. |
|
Implementation looks ok, but I wonder if this really should be inside ScrollBar. It looks like something that should be in ScrollContainer. But then it would become more complex, idk 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ScrollBaris allowed to watch theScrollContainerif both are in the tree.That is, according to the
orientationof thisScrollBar, the correspondingScrollBarin theScrollContaineris shared with thisScrollBar.This patch will make it easy to replace the internal
ScrollBarof the targetScrollContainerin the editor:*_scroll_modeinScrollContainertoSCROLL_MODE_SHOW_NEVER; (Scrolling is not available and will be fixed by Use more reasonable scrollable conditions inScrollContainer#63562.)ScrollBarand set itswatch_target_pathto the path of the targetScrollContainer.Peek.2022-07-29.21-38.mp4
Close godotengine/godot-proposals#5012