Sequential Box<>Box #208
Open
Sequential Box<>Box #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikfrey
approved these changes
May 9, 2025
| @@ -1718,6 +1730,497 @@ def capsule_box( | |||
| ) | |||
|
|
|||
|
|
|||
| @wp.func | |||
| def compute_rotmore(face_idx: int) -> wp.mat33: | |||
There was a problem hiding this comment.
nit: let's prepend the name with an underscore as we probably don't expect others to use this outside this module, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reimplementation of box<>box, based on the mjc code rather than the mjx code. It is sequential and does not make use of tiles, but closer to mjc and may lead to lower thread divergence.
It fixes issues observed in #163