Skip to content

ci: update patterns to include postgres tools and mcp test harness#2988

Closed
anubhav756 wants to merge 1 commit intomainfrom
anubhav-ci
Closed

ci: update patterns to include postgres tools and mcp test harness#2988
anubhav756 wants to merge 1 commit intomainfrom
anubhav-ci

Conversation

@anubhav756
Copy link
Copy Markdown
Contributor

This PR updates the PATTERN regex in .ci/integration.cloudbuild.yaml for all Postgres-related test shards (cloud-sql-pg, alloydb, alloydb-pg, alloydb-omni, and postgres).

The patterns now include internal/tools/postgres and tests/mcp_tool.go. This ensures that changes to Postgres tools or the new MCP test harness will correctly trigger the relevant integration tests in the CI pipeline. Previously, modifications to these directories would not trigger tests unless other shared files were also modified.

This PR updates the `PATTERN` regex in `.ci/integration.cloudbuild.yaml` for all Postgres-related test shards (`cloud-sql-pg`, `alloydb`, `alloydb-pg`, `alloydb-omni`, and `postgres`).

The patterns now include `internal/tools/postgres` and `tests/mcp_tool.go`. This ensures that changes to Postgres tools or the new MCP test harness will correctly trigger the relevant integration tests in the CI pipeline. Previously, modifications to these directories would not trigger tests unless other shared files were also modified.
@anubhav756 anubhav756 self-assigned this Apr 8, 2026
@anubhav756 anubhav756 requested a review from a team as a code owner April 8, 2026 10:03
@anubhav756 anubhav756 closed this Apr 8, 2026
@anubhav756 anubhav756 deleted the anubhav-ci branch April 8, 2026 10:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🧨 Preview deployments removed.

Cloudflare Pages environments for pr-2988 have been deleted.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Google Cloud Build CI configuration by adding internal/tools/postgres and tests/mcp_tool.go to the change detection patterns for various Postgres-related integration test shards. Feedback was provided to also include tests/tool.go in the AlloyDB test pattern to ensure that changes to shared test utilities correctly trigger the integration tests, as tests/mcp_tool.go depends on helper functions within that file.

- -c
- |
PATTERN="alloydb|internal/sources/postgres|tests/postgres|internal/server/|tests/common.go|.ci/"
PATTERN="alloydb|internal/sources/postgres|internal/tools/postgres|tests/postgres|internal/server/|tests/common.go|tests/mcp_tool.go|.ci/"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For consistency with other Postgres-related test shards and to correctly handle dependencies, it's a good idea to also include tests/tool.go in this pattern.

The new test harness tests/mcp_tool.go uses helper functions from tests/tool.go (like RunRequest). Without including tests/tool.go in the pattern, changes to this shared test utility file won't trigger the alloydb integration tests, which could lead to missed regressions.

        PATTERN="alloydb|internal/sources/postgres|internal/tools/postgres|tests/postgres|internal/server/|tests/common.go|tests/tool.go|tests/mcp_tool.go|.ci/"

@anubhav756 anubhav756 restored the anubhav-ci branch April 8, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant