Skip to content

ci: update patterns to include postgres tools and mcp test harness #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anubhav756 wants to merge 1 commit into from
Closed

ci: update patterns to include postgres tools and mcp test harness #2988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .ci/integration.cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ steps:
args:
- -c
- |
PATTERN="cloudsqlpg|internal/sources/postgres|tests/postgres|internal/server/|tests/common.go|tests/tool.go|.ci/"
PATTERN="cloudsqlpg|internal/sources/postgres|internal/tools/postgres|tests/postgres|internal/server/|tests/common.go|tests/tool.go|tests/mcp_tool.go|.ci/"

if grep -qE "$$PATTERN" /workspace/changed_files.txt; then
echo "Relevant changes detected. Starting Cloud SQL Postgres tests..."
Expand Down Expand Up @@ -136,7 +136,7 @@ steps:
args:
- -c
- |
PATTERN="alloydb|internal/sources/postgres|tests/postgres|internal/server/|tests/common.go|.ci/"
PATTERN="alloydb|internal/sources/postgres|internal/tools/postgres|tests/postgres|internal/server/|tests/common.go|tests/mcp_tool.go|.ci/"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For consistency with other Postgres-related test shards and to correctly handle dependencies, it's a good idea to also include tests/tool.go in this pattern.

The new test harness tests/mcp_tool.go uses helper functions from tests/tool.go (like RunRequest). Without including tests/tool.go in the pattern, changes to this shared test utility file won't trigger the alloydb integration tests, which could lead to missed regressions.

        PATTERN="alloydb|internal/sources/postgres|internal/tools/postgres|tests/postgres|internal/server/|tests/common.go|tests/tool.go|tests/mcp_tool.go|.ci/"


if grep -qE "$$PATTERN" /workspace/changed_files.txt; then
echo "Relevant changes detected. Starting AlloyDB tests..."
Expand Down Expand Up @@ -168,7 +168,7 @@ steps:
args:
- -c
- |
PATTERN="alloydbpg|internal/sources/postgres|tests/postgres|internal/server/|tests/common.go|tests/tool.go|.ci/"
PATTERN="alloydbpg|internal/sources/postgres|internal/tools/postgres|tests/postgres|internal/server/|tests/common.go|tests/tool.go|tests/mcp_tool.go|.ci/"

if grep -qE "$$PATTERN" /workspace/changed_files.txt; then
echo "Changes detected. Running AlloyDB Postgres tests..."
Expand Down Expand Up @@ -226,7 +226,7 @@ steps:
args:
- -c
- |
PATTERN="alloydbomni|internal/sources/postgres|internal/server/|tests/common.go|tests/tool.go|.ci/"
PATTERN="alloydbomni|internal/sources/postgres|internal/tools/postgres|internal/server/|tests/common.go|tests/tool.go|tests/mcp_tool.go|.ci/"

if grep -qE "$$PATTERN" /workspace/changed_files.txt; then
echo "Changes detected. Running AlloyDB Omni tests..."
Expand Down Expand Up @@ -454,7 +454,7 @@ steps:
args:
- -c
- |
PATTERN="postgres|internal/server/|tests/common.go|tests/tool.go|.ci/"
PATTERN="postgres|internal/tools/postgres|internal/server/|tests/common.go|tests/tool.go|tests/mcp_tool.go|.ci/"

if grep -qE "$$PATTERN" /workspace/changed_files.txt; then
echo "Changes detected. Running Postgres tests..."
Expand Down
Loading