Improve notifications #16932
Merged
Improve notifications #16932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If require signature is set in the general settings though, an email will be sent. 
|
@snipe I'm not sure I follow. That doesn't seem to be the case on develop (or this PR's branch). |
# Conflicts: # app/Listeners/CheckoutableListener.php
# Conflicts: # app/Listeners/CheckoutableListener.php
marcusmoore
changed the title
marcusmoore
commented
May 20, 2025
Comment on lines
+44
to
+60
| /** | ||
| * Register the listeners for the subscriber. | ||
| * | ||
| * @param Illuminate\Events\Dispatcher $events | ||
| */ | ||
| public function subscribe($events) | ||
| { | ||
| $events->listen( | ||
| \App\Events\CheckoutableCheckedIn::class, | ||
| 'App\Listeners\CheckoutableListener@onCheckedIn' | ||
| ); | ||
|
|
||
| $events->listen( | ||
| \App\Events\CheckoutableCheckedOut::class, | ||
| 'App\Listeners\CheckoutableListener@onCheckedOut' | ||
| ); | ||
| } |
There was a problem hiding this comment.
This is pulled up from the middle of the class.
|
@snipe this PR is ready for review. Thought, regarding your comment above, that is not addressed in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues around checkout/checkin notifications via updates to the
CheckoutableListener.This PR adds more tests around notifications to ensure webhooks, alert emails, and emails to users are sent across a variety of category and application configurations.
It might be helpful to see which tests have been added to the tests directory. Taking the tests from this PR and dropping them into the develop branch shows the following failures:
Before this PR if an checkout/checkin alert email was set in notification settings, the "CC Email" would receive two emails:
With this PR one email is sent:
If the user is not going to receive the email the the alert address is promoted to the
toaddress:Note: I've removed the randomness of the category factory "using a default eula". This removes some test flakiness but also means our seeders no longer seed categories that use the default eula. That is actually more accurate because the settings are not seeded with a default eula.
This PR should address (#16938 and #16897) and might address #16966
What this PR doesn't address and needs to be followed up on:
Send email to user on checkin/checkoutwhen there is a EULA (local or global) being used which means users will always get an email on check in even if that is not the intention by the administrator.