Skip to content

fix: add a retry on span routing #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mterhar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add a retry on span routing #1525

mterhar wants to merge 2 commits into from
+28 −4

Conversation

@mterhar
Copy link
Contributor

@mterhar mterhar commented Apr 10, 2025

Which problem is this PR solving?

Short description of the changes

  • Adds error handling so if it can't add a span to the cache, it will send it elsewhere or process it immediately as a stress behavior

@mterhar mterhar marked this pull request as ready for review April 10, 2025 16:24
@mterhar mterhar requested a review from a team as a code owner April 10, 2025 16:24
jhonmike
jhonmike approved these changes Apr 10, 2025
View reviewed changes
Copy link

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mterhar mterhar changed the title add a retry on span routing fix: add a retry on span routing Apr 11, 2025
@mterhar
Copy link
Contributor Author

mterhar commented Apr 12, 2025 •
edited
Loading

Here's a chart showing the impact of this PR on a cluster that is 30 nodes and handling about a million spans per second.
Screenshot 2025-04-11 at 20 22 17

@mterhar mterhar mentioned this pull request Apr 18, 2025
Draft
@codeboten codeboten mentioned this pull request May 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jhonmike jhonmike jhonmike approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mterhar @jhonmike