Closed
Conversation
imstevenpmwork
previously approved these changes
Jul 20, 2025
Collaborator
imstevenpmwork
left a comment
imstevenpmwork
left a comment
There was a problem hiding this comment.
Sorry for the spam, thanks to this PR I realized that I had some bugs in the new CI pipelines, so I have been using this PR as a reference for community contributions
Collaborator
imstevenpmwork
left a comment
imstevenpmwork
left a comment
There was a problem hiding this comment.
Hello! Now for the actual review ^^
Just a couple of additional notes:
- I think
lerobot/scripts/visualize_dataset.pymight also need to be updated with the latest API changes. Could you please check and modify it as well? - There’s an existing PR (#1375 ) that updates the rerun version and API. While #1375 PR is more comprehensive (adding new features), #1544 is minimal and focused on version compatibility. Ideally, we’d: Merge your PR first (minimal version bump). Then merge #1375 (new feature integration).
- Could you cross-check the API changes in #1375 to ensure consistency?
Thanks for the updates (& for the patience)! 😄
Contributor
Author
|
Thanks for the review!
Good catch. Updated.
Checked, this PR should be a subset of #1375 |
CarolinePascal
added
enhancement
Collaborator
|
Superseded by: #2237 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
We pinned(1, 2) rerun-sdk to below 0.23 due to a memory leak issue. This issue was resolved in 0.24. This PR bumps rerun version and removes the ceil.
In the long run, we should still pin package versions (discussed in #1435) so that new users don't have to deal with breaking changes.
How it was tested
Run teleop with
--display_data=true. Open the memory panel and observe that thecountedmemory doesn't rapidly increase.How to checkout & try? (for the reviewer)
pip install -e .to upgrade rerun.Follow the teleop instructions.