Fix StreamingLeRobotDataset using global index for video frame lookup#3110
Open
he-yufeng wants to merge 1 commit intohuggingface:mainfrom
Open
Fix StreamingLeRobotDataset using global index for video frame lookup#3110he-yufeng wants to merge 1 commit intohuggingface:mainfrom
he-yufeng wants to merge 1 commit intohuggingface:mainfrom
Conversation
github-actions
bot
added
the
dataset
streaming_dataset.py computed current_ts from item["index"] (global dataset index) instead of item["timestamp"] (per-episode timestamp). Since each .mp4 file is per-episode, torchcodec received a frame index far beyond the video length, causing IndexError. Use item["timestamp"] to match what LeRobotDataset.__getitem__ does. Fixes huggingface#3080
he-yufeng
force-pushed
the
fix/streaming-video-frame-index
branch
from
d262d1c to
cdc8182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes
StreamingLeRobotDatasetcrashing withIndexError: Invalid frame indexon datasets with multiple episodes.Root cause
streaming_dataset.py:312computed the current timestamp fromitem["index"](the global dataset index):But each
.mp4file is per-episode, sotorchcodecreceived a frame index far beyond the video length (e.g. frame 134029 in a 25215-frame video), causingIndexError.Fix
Use
item["timestamp"](per-episode timestamp) instead, matching whatLeRobotDataset.__getitem__does at line 1099.Fixes #3080