feat(policy): adding return_extra to policy contracts#3757
Draft
Maximellerbach wants to merge 2 commits into
Draft
feat(policy): adding return_extra to policy contracts#3757Maximellerbach wants to merge 2 commits into
Maximellerbach wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing for more world models
Adding a
return_extrakwargs topredict_action_chunkandselect_action.Main idea behind this is to prepare for different kind of models that might generate things other than actions at runtime.
Why an extra kwarg ?
-> the consumer decides wether he should have the extra data or not, for instance at inference it can be opted out.
The policy would have to implement something like: