Skip to content

Pin to weezl 0.1.8 to resolve CI test failures#206

Closed
bushrat011899 wants to merge 1 commit into
image-rs:masterfrom
bushrat011899:ci_failure_temp_fix
Closed

Pin to weezl 0.1.8 to resolve CI test failures#206
bushrat011899 wants to merge 1 commit into
image-rs:masterfrom
bushrat011899:ci_failure_temp_fix

Conversation

@bushrat011899
Copy link
Copy Markdown
Contributor

Objective

CI currently fails for a reason seemingly unrelated to the PR itself. I have diagnosed the issue as likely being caused by weezl 0.1.9. I verified this by using cargo update --precise to toggle between 0.1.8 and 0.1.9 and could observe the test failures on 0.1.9, and passed on 0.1.8.

Solution

  • Temporarily pinned to 0.1.8 so development here can continue while a long-term fix is investigated (either upstream if the break is unintentional, or here otherwise)

Issue appears to be caused upstream
@bushrat011899
Copy link
Copy Markdown
Contributor Author

Opened an issue here just in case this is an upstream issue. I could see the release notes highlighted a change in behvaiour, but I'm not certain if this failure is intentional, and if so, what the remedy is.

@kornelski
Copy link
Copy Markdown
Contributor

It's important to find out whether that's breakage in weezl or a bug in this crate. Either way there's a bug somewhere, and pinning the version won't fix it, only crate compatibility problems with the crates ecosystem.

@bushrat011899
Copy link
Copy Markdown
Contributor Author

Absolutely, unfortunately I'm not familiar enough with weezl to really nail down the issue, but I do have a handful of PRs planned for this crate I would like to merge in the meantime (thanks for the reviews btw!).

@197g 197g closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants