Skip to content

build: support python 3.14, drop 3.9#290

Open
tlambert03 wants to merge 5 commits into
mainfrom
support-3.14
Open

build: support python 3.14, drop 3.9#290
tlambert03 wants to merge 5 commits into
mainfrom
support-3.14

Conversation

@tlambert03

Copy link
Copy Markdown
Member

No description provided.

@tlambert03 tlambert03 changed the title feat: support python 3.14, drop 3.9 build: support python 3.14, drop 3.9 Oct 13, 2025
@codecov

codecov Bot commented Oct 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.62%. Comparing base (7d64d5f) to head (4a1783a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files          24       24           
  Lines        1120     1120           
=======================================
  Hits         1071     1071           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Oct 13, 2025

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing support-3.14 (6fb336b) with main (c9c5438)

Open in CodSpeed

@psobolewskiPhD

Copy link
Copy Markdown

https://github.com/PyCQA/docformatter was released which should unblock this!

Comment thread pyproject.toml
[tool.pytest.ini_options]
minversion = "6.0"
testpaths = ["tests"]
addopts = '--mypy-only-local-stub --color=yes'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
addopts = '--color=yes'

I think this needs to be removed due to 4.0.0 of pytest-mypy-plugins.
Breaking changes:

  • Breaking: Errors are now ignored in site-packages by default. The --mypy-only-local-stub flag
    has been removed and replaced with --mypy-no-silence-site-packages which can be used to restore
    the previous behavior if needed. This change was made to avoid errors being raised when enabling
    certain mypy options, e.g. the explicit-override error code or the --disallow-subclassing-any
    flag, which resulted in violations due to these not being supported with the stubs provided by
    typeshed for the standard library. In addition, this affected other error codes or flags for some
    third-party libraries in django-stubs.
  • Breaking: When running in a subprocess (the default), PYTHONPATH is no longer set. With the
    above change, violations would still be raised in the main module for a test case, but those that
    were flagged in imported modules would no longer be raised. This was because these modules were
    being added to PYTHONPATH which caused mypy to treat them as belonging in site-packages and not
    as part of the first-party package. The new --mypy-modify-pythonpath flag can be used to revert
    to the previous behavior if needed.

Looks like mypy-only-local-stub can just be removed.
And since here we drop 3.9 support, then can bump the minimum pytest-mypy-plugins to 4.

Comment thread pyproject.toml
"numpy >=2.1; python_version >= '3.13'",
"pytest-codspeed >=2.4.0",
"pytest-cov >=4.0.0",
"pytest-mypy-plugins >=3.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pytest-mypy-plugins >=4.0.0",

See comment below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants