fix: transform/parse ts files and bundle using imports #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbieGoede
changed the title
|
TODO
|
BobbieGoede
changed the title
|
@kazupon |
kazupon
approved these changes
Mar 17, 2025
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the big PR 🙏
I don't have a full understanding of the code base yet, with these changes the virtual bundling of messages to make use of file imports instead of directly transforming/compiling the resources files and combining the results. Now it should rely more on the vite/webpack/rspack functionality to transform the imported files.
I have changed the JS generator to also transform ts to js before parsing and transforming, I tried using oxc transform and parser but that would require additional changes for browser environments. This now uses babel for the transformation which is slower but should work as expected.
Projects using webpack/rspack still need to configure the necessary loaders for typescript in case they want to use ts files for locales.
The additions I made to the generator probably break proper source mapping, at least I have a feeling that it does 🤔
Resolves #266
Related #297
Related #228 (possibly resolves, have not tried)
Replaces #434
Replaces #446