fix: transform/parse ts files and bundle using imports #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the big PR 🙏
I don't have a full understanding of the code base yet, with these changes the virtual bundling of messages to make use of file imports instead of directly transforming/compiling the resources files and combining the results. Now it should rely more on the vite/webpack/rspack functionality to transform the imported files.
I have changed the js generator to first transform the code (in case it is typescript) using
oxc-transformand then parsing it withoxc-parser, this will break the plugin when used in web development environments such as stackblitz, we will need to fallback to@oxc-parser/wasmin that case (like we do in nuxt-i18n and nuxt), but I am not sure if this is needed and/or available for theoxc-transformpackage.