-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Bumps OVRTX runtime dependency to 0.4 #6592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
2143cb7
9da6608
8a209ae
fa1b1bb
b7c9966
2d981d9
1349d0d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Updated the optional OVRTX runtime dependency to ``ovrtx>=0.4.0,<0.5.0``. Reinstall the OVRTX | ||
| extra with ``./isaaclab.sh -i 'ov[ovrtx]'`` to use the supported 0.4 runtime. | ||
|
|
||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Worked around OVRTX 0.4 tiled RenderProducts retaining only cameras present at stage load by | ||
| rewriting the camera relationship after runtime cloning. |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems the red background issue in albedo has been fixed. @rilei-nvidia we have one bug ticket to close.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. However, I can't see the ground. Seems like a regression.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a welcomed change and is expected. Relates to the fix from nvbug 6270556 |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should assign a different diffuse color to the table so that it can be distinguished from the background. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great workaround! It doesn't even look like a workaround from my perspective.
Maybe we should have this code path only for ovrtx 0.4, gating it with a ovrtx version check (
ovrtx.__version__).We'd better keep both 0.3 and 0.4 working separately for easier A/B testing in the short term.