Merged
Conversation
rantoniuk
reviewed
Dec 1, 2025
Member
rantoniuk
left a comment
rantoniuk
left a comment
There was a problem hiding this comment.
Do I understand correctly that after those changes the current checkstyle-idea.xml will work fine?
Contributor
Author
|
@rantoniuk these changes will align the style with Jenkins core. They will not help for checkstyle-idea.xml which is based on Google code style (requires 2 space indentation instead of 4 spaces). |
Member
Then I guess you still want to remove that file as part of this PR as discussed earlier? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #758
Some code style changes to make the code style more aligned with Jenkins core.