Skip to content

Catch Prettier, TypeScript, and ESLint issues in Jenkins#681

Merged
timja merged 4 commits intojenkinsci:mainfrom
felipecrs:eslint-format
Apr 28, 2025
Merged

Catch Prettier, TypeScript, and ESLint issues in Jenkins#681
timja merged 4 commits intojenkinsci:mainfrom
felipecrs:eslint-format

Conversation

@felipecrs
Copy link
Contributor

This should allow Jenkins to fail if there's some ESLint issue.

Testing done

N/A

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@felipecrs
Copy link
Contributor Author

felipecrs commented Apr 28, 2025

@timja, what if we create another pipeline (through GitHub Actions?) that will only run npm lint and npm test? I can send a PR, should be a very simple pipeline anyway.

I think disregarding the exit code is very dangerous...

@felipecrs felipecrs changed the title Add checkstyle format to ESLint Catch ESLint issues in Jenkins Apr 28, 2025
@felipecrs
Copy link
Contributor Author

@timja, what if we create another pipeline (through GitHub Actions?) that will only run npm lint and npm test? I can send a PR, should be a very simple pipeline anyway.

I think disregarding the exit code is very dangerous...

The caveat of this PR's approach is not catching tsc or prettier issues.

@felipecrs felipecrs marked this pull request as ready for review April 28, 2025 15:14
@felipecrs felipecrs requested a review from a team as a code owner April 28, 2025 15:14
@felipecrs felipecrs changed the title Catch ESLint issues in Jenkins Catch Prettier, TypeScript, and ESLint in Jenkins Apr 28, 2025
@felipecrs felipecrs changed the title Catch Prettier, TypeScript, and ESLint in Jenkins Catch Prettier, TypeScript, and ESLint issues in Jenkins Apr 28, 2025
@felipecrs felipecrs requested a review from timja April 28, 2025 19:52
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor things, CI is a standard env var that Jenkins supports for running in CI

Thanks for this

@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Apr 28, 2025
@timja timja enabled auto-merge (squash) April 28, 2025 21:20
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@timja timja merged commit 88a97e2 into jenkinsci:main Apr 28, 2025
17 checks passed
@felipecrs felipecrs deleted the eslint-format branch April 28, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a PR that adds to maintenance - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants