Catch Prettier, TypeScript, and ESLint issues in Jenkins#681
Merged
timja merged 4 commits intojenkinsci:mainfrom Apr 28, 2025
felipecrs:eslint-format
Merged
Catch Prettier, TypeScript, and ESLint issues in Jenkins#681timja merged 4 commits intojenkinsci:mainfrom felipecrs:eslint-format
timja merged 4 commits intojenkinsci:mainfrom
felipecrs:eslint-format
Conversation
Contributor
Author
|
@timja, what if we create another pipeline (through GitHub Actions?) that will only run I think disregarding the exit code is very dangerous... |
6 tasks
felipecrs
commented
Apr 28, 2025
felipecrs
commented
Apr 28, 2025
Contributor
Author
The caveat of this PR's approach is not catching |
timja
reviewed
Apr 28, 2025
…ew-plugin into eslint-format
6 tasks
timja
reviewed
Apr 28, 2025
Member
timja
left a comment
There was a problem hiding this comment.
few minor things, CI is a standard env var that Jenkins supports for running in CI
Thanks for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow Jenkins to fail if there's some ESLint issue.
Testing done
N/A
Submitter checklist