Add new GitHub Actions pipeline for frontend#683
Closed
felipecrs wants to merge 2 commits intojenkinsci:mainfrom
felipecrs:new-pipeline
Closed
Add new GitHub Actions pipeline for frontend#683felipecrs wants to merge 2 commits intojenkinsci:mainfrom felipecrs:new-pipeline
felipecrs wants to merge 2 commits intojenkinsci:mainfrom
felipecrs:new-pipeline
Conversation
felipecrs
changed the title
Contributor
Author
|
@timja, this is what I had in mind. What do you think? |
timja
reviewed
Apr 28, 2025
| "scripts": { | ||
| "mvnbuild": "npm run build", | ||
| "mvntest": "npm test", | ||
| "mvntest": "echo \"Tests should be executed through 'npm test' instead\"", |
Member
There was a problem hiding this comment.
we still want this to be run through the maven build so that a full build is tested for both java and javascript.
People can skip the running of the tests easily with e.g. quick-build profile and on CI I don't think it matters much
timja
reviewed
Apr 28, 2025
|
|
||
| <!-- Opt in to Jenkins handling eslint results --> | ||
| <maven.test.failure.ignore>false</maven.test.failure.ignore> | ||
| <frontend.testFailureIgnore>${maven.test.failure.ignore}</frontend.testFailureIgnore> |
Member
There was a problem hiding this comment.
this also has the benefit that check annotations show up in the GitHub UI which is a nice feature, so not sure if we want to remove this
6 tasks
Contributor
Author
|
If we can fix #681 (comment), I'd rather abandon this. |
6 tasks
Contributor
Author
|
No longer needed thanks to #681 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#681 (comment).
Testing done
N/A
Submitter checklist