Fix saving notebook with disconnected widgets losing widget model state#4015
Open
pablogsal wants to merge 1 commit intojupyter-widgets:mainfrom
Open
Fix saving notebook with disconnected widgets losing widget model state#4015pablogsal wants to merge 1 commit intojupyter-widgets:mainfrom
pablogsal wants to merge 1 commit intojupyter-widgets:mainfrom
Conversation
When saving a notebook containing disconnected widgets (restored from saved state but without a live kernel), the widget state was being dropped from notebook metadata. This happened because get_state_sync() only serialized models with comm_live=true, filtering out any widgets that had been restored from saved state without a kernel connection. On subsequent reopens, the widget output cells still referenced model IDs that no longer existed in the metadata, causing "Error displaying widget: model not found" errors. The fix removes the comm_live filter from get_state_sync(), so all registered widget models are serialized when saving. This aligns with the base manager's async get_state() method, which already includes all models regardless of comm_live status. Fixes jupyter-widgets#3270
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving a notebook containing disconnected widgets (restored from saved state but without a live kernel), the widget state was being dropped from notebook metadata. This happened because get_state_sync() only serialized models with comm_live=true, filtering out any widgets that had been restored from saved state without a kernel connection.
On subsequent reopens, the widget output cells still referenced model IDs that no longer existed in the metadata, causing "Error displaying widget: model not found" errors.
The fix removes the comm_live filter from get_state_sync(), so all registered widget models are serialized when saving. This aligns with the base manager's async get_state() method, which already includes all models regardless of comm_live status.
Fixes #3270