Skip to content

Fix saving notebook with disconnected widgets losing widget model state #4015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pablogsal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix saving notebook with disconnected widgets losing widget model state #4015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions python/jupyterlab_widgets/src/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,9 @@ export abstract class LabWidgetManager
}

/**
* Synchronously get the state of the live widgets in the widget manager.
* Synchronously get the state of the widget models in the widget manager.
*
* This includes all of the live widget models, and follows the format given in
* This includes all of the widget models, and follows the format given in
* the @jupyter-widgets/schema package.
*
* @param options - The options for what state to return.
Expand All @@ -298,9 +298,7 @@ export abstract class LabWidgetManager
get_state_sync(options: IStateOptions = {}): ReadonlyPartialJSONValue {
const models = [];
for (const model of this._modelsSync.values()) {
if (model.comm_live) {
models.push(model);
}
models.push(model);
}
return serialize_state(models, options);
}
Expand Down