Replace hack/krtequals with standalone krtequals module #13091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gateway-bot
added
kind/cleanup
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the in-tree hack/krtequals linter implementation with a standalone module (github.com/kgateway-dev/krtequals). The change consolidates the custom linter into an external, independently maintained module with enhanced test coverage and additional configuration options like checkUnexported.
Key Changes:
- Complete removal of the local
hack/krtequalsdirectory including analyzer code, tests, and testdata - Configuration updates to reference the external module via
.custom-gcl.yml - Addition of
checkUnexported: truesetting in.golangci.yaml
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .custom-gcl.yml | Updates module reference from local ./hack/krtequals to external github.com/kgateway-dev/krtequals with version pinning |
| .golangci.yaml | Adds checkUnexported: true configuration for the krtequals linter |
| Makefile | Removes hack/krtequals from the nested module tidy targets |
| hack/krtequals/analyzer.go | Deletes the entire in-tree analyzer implementation (295 lines) |
| hack/krtequals/plugin.go | Deletes the golangci-lint plugin wrapper |
| hack/krtequals/analyzer_test.go | Deletes analyzer tests |
| hack/krtequals/go.mod | Removes module definition for the local linter |
| hack/krtequals/go.sum | Removes dependency checksums |
| hack/krtequals/testdata/src/markers/markers.go | Deletes test data for marker functionality |
| hack/krtequals/testdata/src/deepequalon/deepequal.go | Deletes test data for DeepEqual check |
| hack/krtequals/testdata/src/deepequaloff/deepequal.go | Deletes test data for DeepEqual disabled mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yuval-k
approved these changes
Dec 11, 2025
Replace the in-tree hack/krtequals linter implementation with the standalone krtequals module (github.com/kgateway-dev/krtequals). The standalone module provides: - Improved test coverage for edge cases (chained expressions, delegated Equals calls, method arguments) - New checkUnexported config option to lint unexported struct fields - golangci-lint module plugin integration - Cleaner separation of concerns The original implementation has been ported and enhanced in the standalone repository with more robust testing and additional configuration options. Note: I disabled the checkUnexported config option for now. There's linting violations that will need to be burned down as a follow-up. Signed-off-by: timflannagan <[email protected]>
timflannagan
force-pushed
the
chore/update-krtequals
branch
from
8dca98f to
44c5251
Compare
Member
Author
|
@yuval-k Had to flip the config option that checks for unexported fields in the latest force push to get CI back online. My backlog is a bit deep right now, so I'll likely create a follow-up issue to burn down these failures and enable that config option. |
yuval-k
approved these changes
Dec 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2025
Signed-off-by: timflannagan <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2025
Signed-off-by: timflannagan <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the in-tree hack/krtequals linter implementation with the standalone krtequals module (github.com/kgateway-dev/krtequals).
The standalone module provides:
The original implementation has been ported and enhanced in the standalone repository with more robust testing and additional configuration options.
Note: I disabled the checkUnexported config option for now. There's linting violations that will need to be burned down as a follow-up.
See https://github.com/kgateway-dev/kgateway/actions/runs/20117197292/job/57729346589?pr=13091 for evidence on the current linting violations when the checkUnexported field has been enabled.
Fixes #13090.
Change Type
/kind cleanup
Changelog
Additional Notes
New repo: https://github.com/kgateway-dev/krtequals