Add deploy logs, Fix projected gravity computation #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loyments. add 3d visualizer for the quat over the course of rollout
jingxiangmo
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances deployment logging and visualization while refactoring deployment classes for improved structure and reliability. Key changes include adding new fields (model, timestamp, quat) and statistics to deployment logs with a daily folder structure; implementing a 3D IMU visualizer; and adjusting joystick deployment classes to use the unified Deploy base class.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ksim_kbot/deploy/deployment_logs/plot_logs.py | Updated logging, added new fields and statistics, refactored file loading with argument support. |
| ksim_kbot/deploy/deployment_logs/plot_3d_imu.py | New module for generating 3D visualization video of quaternion data with improved frame handling. |
| ksim_kbot/deploy/deploy_joystick_rnn.py | Refactored to use Deploy base class and updated rollout dictionary with additional fields. |
| ksim_kbot/deploy/deploy_joystick.py | Similar updates to rollout storage and episode length adjustments. |
| ksim_kbot/deploy/deploy.py | Updated file saving logic to create a daily folder structure and removed the FixedArmDeploy subclass. |
| ksim_kbot/deploy/init.py | Removed FixedArmDeploy from public API. |
Files not reviewed (1)
- ksim_kbot/requirements.txt: Language not supported
Comment on lines
+34
to
+37
| print(f"Date folder not found: {date_str}") | ||
| return None | ||
|
|
||
| print(f"Found date folder: {date_str}") |
There was a problem hiding this comment.
Consider using logger.error instead of print for consistent error reporting.
Suggested change
| print(f"Date folder not found: {date_str}") | |
| return None | |
| print(f"Found date folder: {date_str}") | |
| logger.error(f"Date folder not found: {date_str}") | |
| return None | |
| logger.info(f"Found date folder: {date_str}") |
Co-authored-by: Copilot <[email protected]>
|
|
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add fields "model" for model used, timestamp, and quat to the log deployments.
add 3d visualizer for the quat over the course of rollout
automatic daily folder structure for pickle files
add arguments in plotting of deployment which day and which deployment type to plot