fix: correct storageclass annotations and node dnsPolicy in latest chart#1102
Conversation
- Move annotations key inside with block to avoid rendering null annotations - Fix node DaemonSet dnsPolicy to use node.dnsPolicy instead of controller.dnsPolicy
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XS
andyzhangx
removed
the
do-not-merge/release-note-label-needed
There was a problem hiding this comment.
Pull request overview
Aligns the charts/latest/ Helm chart templates with fixes already present in the v4.13.2 chart, addressing incorrect rendering/values wiring in the “latest” chart variant.
Changes:
- Fix
storageclass.yamlsometadata.annotationsis only rendered when.Values.storageClass.annotationsis set (avoidsannotations: null). - Fix
csi-nfs-node.yamlto source the node DaemonSetdnsPolicyfrom.Values.node.dnsPolicy(not the controller value). - Regenerate the packaged Helm chart archive (
csi-driver-nfs-v0.0.0.tgz).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/latest/csi-driver-nfs/templates/storageclass.yaml | Wraps annotations: under a with block so it isn’t emitted when unset. |
| charts/latest/csi-driver-nfs/templates/csi-nfs-node.yaml | Corrects dnsPolicy to use the node-specific values key. |
| charts/latest/csi-driver-nfs-v0.0.0.tgz | Updates the packaged chart artifact to include the template changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Cherry-pick of PR kubernetes-csi#1102 for release-4.13 branch. - Move annotations key inside with block to avoid rendering null annotations - Fix node DaemonSet dnsPolicy to use node.dnsPolicy instead of controller.dnsPolicy
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rt-issues fix: correct storageclass annotations and node dnsPolicy in latest chart
fix: cherry-pick #1102 - correct storageclass annotations and node dnsPolicy in latest chart
Cherry-pick of PR kubernetes-csi#1102 for release-4.13 branch. - Move annotations key inside with block to avoid rendering null annotations - Fix node DaemonSet dnsPolicy to use node.dnsPolicy instead of controller.dnsPolicy
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes two issues in
charts/latest/that were already fixed incharts/v4.13.2/(PR #1099) but not applied to the latest chart:annotations:key was rendered outside thewithblock, causingannotations: nullwhen.Values.storageClass.annotationsis unsetdnsPolicywas using.Values.controller.dnsPolicyinstead of.Values.node.dnsPolicyChanges:
storageclass.yaml: moveannotations:inside thewithblockcsi-nfs-node.yaml: use.Values.node.dnsPolicy