e2e(FR-759): fix create test code#3442
Merged
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.32% | 408/9446 |
| 🔴 | Branches | 3.69% | 240/6512 |
| 🔴 | Functions | 2.62% | 79/3016 |
| 🔴 | Lines | 4.26% | 393/9235 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 8fea3fc
5 tasks
ironAiken2
force-pushed
the
feat_FR-636_/create-test-code
branch
from
882f933 to
550d41a
Compare
5 tasks
agatha197
force-pushed
the
feat_FR-636_/create-test-code
branch
from
550d41a to
6a482b3
Compare
agatha197
changed the title
5 tasks
agatha197
changed the title
ironAiken2
force-pushed
the
feat_FR-636_/create-test-code
branch
from
6a482b3 to
550d41a
Compare
agatha197
force-pushed
the
feat_FR-636_/create-test-code
branch
from
550d41a to
6a482b3
Compare
ironAiken2
force-pushed
the
feat_FR-636_/create-test-code
branch
from
6a482b3 to
550d41a
Compare
agatha197
force-pushed
the
feat_FR-636_/create-test-code
branch
from
550d41a to
6154199
Compare
ironAiken2
force-pushed
the
feat_FR-636_/create-test-code
branch
from
6154199 to
de1b5ba
Compare
ironAiken2
approved these changes
Apr 4, 2025
agatha197
force-pushed
the
feat_FR-636_/create-test-code
branch
2 times, most recently
from
4254a5f to
23e06c2
Compare
Merge activity
|
resolves #3450 (FR-759) >[!NOTE] > This PR only handles creation. ## Update folder creation test and add data-testid attributes This PR updates the folder creation test in `e2e/test-util.ts` to work with the new UI components. The changes include: 1. Removing the 'wd' (Delete) permission option as it's no longer supported 2. Updating the folder creation workflow to use the "Create Folder" button 3. Adding data-testid attributes to radio buttons in FolderCreateModal for better test targeting 4. Updating the folder verification process to work with the new UI components **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
Bot
force-pushed
the
feat_FR-636_/create-test-code
branch
from
23e06c2 to
8fea3fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3450 (FR-759)
Note
This PR only handles creation.
Update folder creation test and add data-testid attributes
This PR updates the folder creation test in
e2e/test-util.tsto work with the new UI components. The changes include:Checklist: