Skip to content

e2e(FR-759): add vfolder restore test code#3451

Merged
graphite-app[bot] merged 1 commit into
mainfrom
feat_FR-759_/restore-vfolder-test-code
Apr 4, 2025
Merged

e2e(FR-759): add vfolder restore test code#3451
graphite-app[bot] merged 1 commit into
mainfrom
feat_FR-759_/restore-vfolder-test-code

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 2, 2025

resolves #3450 (FR-759)

Add VFolder Restoration Functionality and Test

This PR adds a new utility function restoreVFolderAndVerify to support restoring virtual folders from the trash. It also adds a comprehensive test case that verifies the complete lifecycle of a virtual folder: creation, moving to trash, restoration, and permanent deletion.

The new test ensures users can successfully restore folders from the trash before permanently deleting them, providing better test coverage for the virtual folder management workflow.

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 changed the title feat(FR-759): add vfolder restore test code e2e(FR-759): add vfolder restore test code Apr 2, 2025
@agatha197 agatha197 changed the title e2e(FR-759): add vfolder restore test code (FR-759): add vfolder restore test code Apr 2, 2025
@agatha197 agatha197 changed the title (FR-759): add vfolder restore test code e2e(FR-759): add vfolder restore test code Apr 2, 2025
@ironAiken2 ironAiken2 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from b4fb869 to 936d54f Compare April 2, 2025 08:19
@agatha197 agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 936d54f to 7d028d1 Compare April 2, 2025 08:43
@agatha197 agatha197 force-pushed the feat_FR-759_/restore-vfolder-test-code branch from 76e7edc to 88d56ee Compare April 2, 2025 08:43
@agatha197 agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 7d028d1 to 424a439 Compare April 2, 2025 08:45
@agatha197 agatha197 force-pushed the feat_FR-759_/restore-vfolder-test-code branch 2 times, most recently from 9461cb7 to 1182c83 Compare April 2, 2025 08:51
@github-actions github-actions Bot added size:S 10~30 LoC and removed size:M 30~100 LoC labels Apr 2, 2025
@ironAiken2 ironAiken2 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 424a439 to 1ee30d9 Compare April 2, 2025 08:55
@agatha197 agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 1ee30d9 to 682c678 Compare April 2, 2025 09:33
@agatha197 agatha197 force-pushed the feat_FR-759_/restore-vfolder-test-code branch 2 times, most recently from 6b15fdd to 0c5c2b6 Compare April 2, 2025 09:35
@github-actions github-actions Bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Apr 2, 2025
Comment thread e2e/test-util.ts Outdated
Comment thread e2e/vfolder.test.ts Outdated
@ironAiken2 ironAiken2 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 682c678 to ecc217c Compare April 4, 2025 04:18
@agatha197 agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from ecc217c to af3ac55 Compare April 4, 2025 04:36
@agatha197 agatha197 force-pushed the feat_FR-759_/restore-vfolder-test-code branch from 0c5c2b6 to 43d10dd Compare April 4, 2025 04:36
@github-actions github-actions Bot added size:S 10~30 LoC and removed size:M 30~100 LoC labels Apr 4, 2025
@agatha197 agatha197 force-pushed the feat_FR-759_/restore-vfolder-test-code branch from 8edc6fd to 6906037 Compare April 4, 2025 05:17
@github-actions github-actions Bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Apr 4, 2025
@agatha197 agatha197 force-pushed the feat_FR-759_/restore-vfolder-test-code branch from 6906037 to b294265 Compare April 4, 2025 05:27
@agatha197 agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 1b810e7 to 763ebb9 Compare April 4, 2025 05:27
@github-actions github-actions Bot added size:S 10~30 LoC and removed size:M 30~100 LoC labels Apr 4, 2025
@agatha197 agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 763ebb9 to 599496f Compare April 4, 2025 05:29
@agatha197 agatha197 force-pushed the feat_FR-759_/restore-vfolder-test-code branch from b294265 to a5d0553 Compare April 4, 2025 05:29
@agatha197 agatha197 requested a review from nowgnuesLee April 4, 2025 05:34
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 599496f to d040389 Compare April 4, 2025 08:41
@agatha197 agatha197 force-pushed the feat_FR-759_/restore-vfolder-test-code branch from a5d0553 to de62ec8 Compare April 4, 2025 08:41
@agatha197 agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from d040389 to c1155a6 Compare April 4, 2025 09:26
@agatha197 agatha197 force-pushed the feat_FR-759_/restore-vfolder-test-code branch from de62ec8 to 1046c75 Compare April 4, 2025 09:26
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 4, 2025

Merge activity

@graphite-app graphite-app Bot force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from c1155a6 to 7dcf1d6 Compare April 4, 2025 09:30
graphite-app Bot pushed a commit that referenced this pull request Apr 4, 2025
resolves #3450 (FR-759)

# Add VFolder Restoration Functionality and Test

This PR adds a new utility function `restoreVFolderAndVerify` to support restoring virtual folders from the trash. It also adds a comprehensive test case that verifies the complete lifecycle of a virtual folder: creation, moving to trash, restoration, and permanent deletion.

The new test ensures users can successfully restore folders from the trash before permanently deleting them, providing better test coverage for the virtual folder management workflow.

**Checklist:**

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app Bot force-pushed the feat_FR-759_/restore-vfolder-test-code branch from 1046c75 to 5268226 Compare April 4, 2025 09:30
@graphite-app graphite-app Bot changed the base branch from feat_FR-636_/add-delete-and-delete-forever-test-case to main April 4, 2025 09:33
resolves #3450 (FR-759)

# Add VFolder Restoration Functionality and Test

This PR adds a new utility function `restoreVFolderAndVerify` to support restoring virtual folders from the trash. It also adds a comprehensive test case that verifies the complete lifecycle of a virtual folder: creation, moving to trash, restoration, and permanent deletion.

The new test ensures users can successfully restore folders from the trash before permanently deleting them, providing better test coverage for the virtual folder management workflow.

**Checklist:**

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app Bot force-pushed the feat_FR-759_/restore-vfolder-test-code branch from 5268226 to 18247a3 Compare April 4, 2025 09:34
@github-actions github-actions Bot added size:L 100~500 LoC and removed size:S 10~30 LoC labels Apr 4, 2025
@graphite-app graphite-app Bot merged commit 18247a3 into main Apr 4, 2025
5 checks passed
@graphite-app graphite-app Bot deleted the feat_FR-759_/restore-vfolder-test-code branch April 4, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor vfolder test codes

2 participants