e2e(FR-759): add delete and delete-forever test case by agatha197 · Pull Request #3445 · lablup/backend.ai-webui

agatha197 · 2025-04-02T07:29:01Z

Refactor VFolder E2E Tests with Improved Test Utilities

This PR adds new utility functions for VFolder operations in E2E tests:

Added verifyVFolder utility function to check folder visibility in the data view
Replaced deleteVFolderAndVerify with two more specific functions:
- moveToTrashAndVerify: Moves a folder to trash and verifies it appears there
- deleteForeverAndVerifyFromTrash: Permanently deletes a folder from trash and verifies it's gone

The new functions better reflect the actual user workflow of first moving items to trash before permanent deletion, and use the new UI components rather than the old Vaadin grid elements.

All existing test cases have been updated to use these new utility functions, making the tests more maintainable and accurate.

Checklist:

Documentation
Minium required manager version
Specific setting for review (eg., KB link, endpoint or how to setup)
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

agatha197 · 2025-04-02T07:29:16Z

e2e(FR-759): add delete and delete-forever test case #3445 : 2 dependent PRs (#3446 , #3451 ) 👈 (View in Graphite)
e2e(FR-759): fix create test code #3442
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

ironAiken2

LGTM

nowgnuesLee

LGTM

agatha197 · 2025-04-04T05:33:53Z

@ironAiken2 @nowgnuesLee I didn't want to make data changes before and after the test, so I changed e2e/vfolder.test.ts to call both delete, deleteforever. And add removeSearchButton function to reduce duplicated codes. Please check it again :)

nowgnuesLee

LGTM

ironAiken2

LGTM

graphite-app · 2025-04-04T09:29:01Z

Merge activity

Apr 4, 5:29 AM EDT: agatha197 added this pull request to the Graphite merge queue.
Apr 4, 5:30 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #3442.
Apr 4, 5:32 AM EDT: agatha197 added this pull request to the Graphite merge queue.
Apr 4, 5:32 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #3442.
Apr 4, 5:33 AM EDT: agatha197 added this pull request to the Graphite merge queue.
Apr 4, 9:37 AM UTC: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.

resolves #3450 (FR-759) # Refactor VFolder E2E Tests with Improved Test Utilities This PR adds new utility functions for VFolder operations in E2E tests: 1. Added `verifyVFolder` utility function to check folder visibility in the data view 2. Replaced `deleteVFolderAndVerify` with two more specific functions: - `moveToTrashAndVerify`: Moves a folder to trash and verifies it appears there - `deleteForeverAndVerifyFromTrash`: Permanently deletes a folder from trash and verifies it's gone The new functions better reflect the actual user workflow of first moving items to trash before permanent deletion, and use the new UI components rather than the old Vaadin grid elements. All existing test cases have been updated to use these new utility functions, making the tests more maintainable and accurate. **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after

agatha197

It is already applied in main branch. close this issue.

github-actions Bot assigned agatha197 Apr 2, 2025

github-actions Bot added the size:L 100~500 LoC label Apr 2, 2025

agatha197 mentioned this pull request Apr 2, 2025

e2e(FR-759): fix create test code #3442

Merged

5 tasks

agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch 2 times, most recently from 2a1ce2a to eb355b0 Compare April 2, 2025 07:32

agatha197 requested review from ironAiken2, lizable, nowgnuesLee and yomybaby April 2, 2025 07:32

ironAiken2 force-pushed the feat_FR-636_/create-test-code branch from 882f933 to 550d41a Compare April 2, 2025 07:35

ironAiken2 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from eb355b0 to 7af3322 Compare April 2, 2025 07:35

ironAiken2 mentioned this pull request Apr 2, 2025

e2e(FR-759): fix test code for vFolder invitation test cases #3446

Merged

5 tasks

agatha197 force-pushed the feat_FR-636_/create-test-code branch from 550d41a to 6a482b3 Compare April 2, 2025 07:45

agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch 2 times, most recently from 4394f15 to b4fb869 Compare April 2, 2025 07:51

agatha197 changed the title ~~feat(FR-636): add delete and delete-forever test case~~ feat(FR-759): add delete and delete-forever test case Apr 2, 2025

agatha197 mentioned this pull request Apr 2, 2025

e2e(FR-759): add vfolder restore test code #3451

Merged

5 tasks

agatha197 changed the title ~~feat(FR-759): add delete and delete-forever test case~~ e2e(FR-759): add delete and delete-forever test case Apr 2, 2025

ironAiken2 force-pushed the feat_FR-636_/create-test-code branch from 6a482b3 to 550d41a Compare April 2, 2025 08:19

ironAiken2 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from b4fb869 to 936d54f Compare April 2, 2025 08:19

agatha197 marked this pull request as draft April 2, 2025 08:23

agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 936d54f to 7d028d1 Compare April 2, 2025 08:43

agatha197 force-pushed the feat_FR-636_/create-test-code branch from 550d41a to 6a482b3 Compare April 2, 2025 08:43

agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 7d028d1 to 424a439 Compare April 2, 2025 08:45

agatha197 marked this pull request as ready for review April 2, 2025 08:46

ironAiken2 force-pushed the feat_FR-636_/create-test-code branch from 6a482b3 to 550d41a Compare April 2, 2025 08:55

ironAiken2 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 424a439 to 1ee30d9 Compare April 2, 2025 08:55

agatha197 force-pushed the feat_FR-636_/create-test-code branch from 550d41a to 6154199 Compare April 2, 2025 09:33

agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 1ee30d9 to 682c678 Compare April 2, 2025 09:33

ironAiken2 force-pushed the feat_FR-636_/create-test-code branch from 6154199 to de1b5ba Compare April 4, 2025 04:18

ironAiken2 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 682c678 to ecc217c Compare April 4, 2025 04:18

agatha197 force-pushed the feat_FR-636_/create-test-code branch from de1b5ba to 4254a5f Compare April 4, 2025 04:36

agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from ecc217c to af3ac55 Compare April 4, 2025 04:36

ironAiken2 approved these changes Apr 4, 2025

View reviewed changes

nowgnuesLee approved these changes Apr 4, 2025

View reviewed changes

agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch 2 times, most recently from 1b810e7 to 763ebb9 Compare April 4, 2025 05:27

agatha197 force-pushed the feat_FR-636_/create-test-code branch from 4254a5f to 23e06c2 Compare April 4, 2025 05:27

agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from 763ebb9 to 599496f Compare April 4, 2025 05:29

agatha197 requested review from ironAiken2 and nowgnuesLee April 4, 2025 05:30

nowgnuesLee approved these changes Apr 4, 2025

View reviewed changes

ironAiken2 approved these changes Apr 4, 2025

View reviewed changes

agatha197 force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch 2 times, most recently from d040389 to c1155a6 Compare April 4, 2025 09:26

graphite-app Bot force-pushed the feat_FR-636_/create-test-code branch from 23e06c2 to 8fea3fc Compare April 4, 2025 09:29

graphite-app Bot force-pushed the feat_FR-636_/add-delete-and-delete-forever-test-case branch from c1155a6 to 7dcf1d6 Compare April 4, 2025 09:30

Base automatically changed from feat_FR-636_/create-test-code to main April 4, 2025 09:32

agatha197 commented Apr 7, 2025

View reviewed changes

agatha197 closed this Apr 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

e2e(FR-759): add delete and delete-forever test case#3445

e2e(FR-759): add delete and delete-forever test case#3445
agatha197 wants to merge 1 commit into
mainfrom
feat_FR-636_/add-delete-and-delete-forever-test-case

agatha197 commented Apr 2, 2025 •

edited

Loading

Uh oh!

agatha197 commented Apr 2, 2025 •

edited

Loading

Uh oh!

ironAiken2 left a comment

Uh oh!

nowgnuesLee left a comment

Uh oh!

agatha197 commented Apr 4, 2025

Uh oh!

nowgnuesLee left a comment

Uh oh!

ironAiken2 left a comment

Uh oh!

graphite-app Bot commented Apr 4, 2025 •

edited

Loading

Uh oh!

agatha197 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

agatha197 commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Refactor VFolder E2E Tests with Improved Test Utilities

Uh oh!

agatha197 commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Uh oh!

agatha197 commented Apr 4, 2025

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

agatha197 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

agatha197 commented Apr 2, 2025 •

edited

Loading

agatha197 commented Apr 2, 2025 •

edited

Loading

graphite-app Bot commented Apr 4, 2025 •

edited

Loading