fix(FR-2627): forward api_version/date/endpoint to token_login#6893
Closed
Conversation
The eduApp route's nuqs allowlist was missing the LMS signing envelope keys (api_version, date, endpoint). The pre-migration _token_login in EduAppLauncher forwarded every URL param except sToken/stoken; the nuqs migration replaced that with an explicit allowlist and dropped these unlisted keys. Manager-side auth hooks that validate the signed launcher URL against these fields would then reject token_login as tampered.
This was referenced Apr 22, 2026
Contributor
Author
5 tasks
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.92% | 1830/20515 |
| 🔴 | Branches | 8.1% | 1165/14391 |
| 🔴 | Functions | 5.28% | 294/5568 |
| 🔴 | Lines | 8.65% | 1722/19908 |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from ca03dc3
Contributor
Author
nowgnuesLee
deleted the
04-22-fix_fr-2627_forward_api_version_date_endpoint_to_token_login
branch
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6864 (FR-2627).
Summary
The
eduAppExtraParamSpecnuqs allowlist inreact/src/routes.tsxwas missing three keys that the pre-migrationEduAppLauncher._token_loginused to forward as part of the body:api_versiondateendpointThe old implementation iterated every
URLSearchParamsentry and forwarded everything exceptsToken/stoken. The nuqs migration replaced that with an explicit allowlist and silently dropped these unlisted keys, soPOST /server/token-loginwent out with a body that only contained{ sToken, app, session_id, ... }— no signing envelope.Backend.AI Manager auth hooks that validate the LMS-signed launcher URL against these fields would then reject the request as tampered, breaking sToken entry into
/edu-applauncherand/applauncher.Fix
Add
api_version,date,endpointtoeduAppExtraParamSpecwith a comment explaining why these must stay in the spec.Test plan
bash scripts/verify.sh→ALL PASS/edu-applauncher?sToken=<signed>&app=jupyterlab&api_version=...&date=...&endpoint=...&session_id=...and confirmPOST /server/token-loginbody includes all five extra keys