feat(FR-2626): migrate LoginView sToken path to STokenLoginBoundary by nowgnuesLee · Pull Request #6861 · lablup/backend.ai-webui

nowgnuesLee · 2026-04-22T02:44:48Z

Resolves FR-2636, FR-2637, FR-2638 (under Story FR-2626, Epic FR-2616)

resolves #NNN (FR-MMM)

Checklist: (if applicable)

Documentation
Minium required manager version
Specific setting for review (eg., KB link, endpoint or how to setup)
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

Stack

Story 2 of Epic FR-2616. See dev plan for the full story breakdown.

nowgnuesLee · 2026-04-22T02:45:05Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-22T02:48:16Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	8.91% (+0% 🔼)	1832/20567
🔴	Branches	8.07% (-0.01% 🔻)	1165/14433
🔴	Functions	5.3% (+0.02% 🔼)	295/5568
🔴	Lines	8.64% (+0% 🔼)	1724/19956

Test suite run success

865 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from 79e6dc4

Copilot

Pull request overview

Migrates the sToken (SSO token) URL-entry login path out of LoginView and into a dedicated route-level STokenLoginBoundary, so the main login/layout tree no longer reads auth state directly from URL query params.

Changes:

Added a route-level STokenGuard that mounts STokenLoginBoundary when sToken/stoken exists, and clears the query params on success.
Introduced persistPostLoginState() helper to centralize post-login side effects for token-based login success.
Removed the legacy sToken URL parsing + token login flow from LoginView.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`react/src/routes.tsx`	Adds `STokenGuard` and wraps root routes so token-based login is handled before rendering the normal app tree.
`react/src/helper/loginSessionAuth.ts`	Adds `persistPostLoginState()` to persist common “successful login” side effects for token-based login.
`react/src/components/LoginView.tsx`	Removes in-component `sToken` URL handling; relies on route-level boundary instead.

yomybaby

LGTM

graphite-app · 2026-04-23T10:31:30Z

Merge activity

Apr 23, 10:31 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 23, 10:46 AM UTC: Merged by the Graphite merge queue.

…6861) Resolves FR-2636, FR-2637, FR-2638 (under Story [FR-2626](https://lablup.atlassian.net/browse/FR-2626), Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616)) resolves #NNN (FR-MMM)   **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after ## Stack Story 2 of Epic FR-2616. See [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full story breakdown. [FR-2626]: https://lablup.atlassian.net/browse/FR-2626?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

…6865) Resolves FR-2639 and FR-2643 (under Stories [FR-2626](https://lablup.atlassian.net/browse/FR-2626) / [FR-2627](https://lablup.atlassian.net/browse/FR-2627), Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616)) resolves #NNN (FR-MMM)   **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after ## Stack Story 2/3 E2E regression for Epic FR-2616. Sits on top of the Story 2 (#6861) and Story 3 (#6864) implementation PRs. [FR-2626]: https://lablup.atlassian.net/browse/FR-2626?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [FR-2627]: https://lablup.atlassian.net/browse/FR-2627?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

github-actions Bot assigned nowgnuesLee Apr 22, 2026

github-actions Bot added the size:L 100~500 LoC label Apr 22, 2026

nowgnuesLee mentioned this pull request Apr 22, 2026

feat(FR-2632): add default fallback and error card UI for STokenLoginBoundary #6855

Merged

5 tasks

This was referenced Apr 22, 2026

test(FR-2633): add unit tests for STokenLoginBoundary #6856

Merged

refactor(FR-2616): rely on React Compiler ('use memo') for memoization #6857

Merged

This was referenced Apr 22, 2026

feat(FR-2627): migrate EduAppLauncher sToken path to STokenLoginBoundary #6864

Merged

test(FR-2639): add E2E regression for sToken login boundary routes #6865

Merged

nowgnuesLee force-pushed the 04-22-feat_fr-2626_migrate_loginview_stoken_path_to_stokenloginboundary branch from 7c7561a to fc0f377 Compare April 22, 2026 03:43

nowgnuesLee force-pushed the 04-22-refactor_fr-2616_rely_on_react_compiler_use_memo_for_memoization branch from 6dcbbec to 19bc0b6 Compare April 22, 2026 03:44

nowgnuesLee force-pushed the 04-22-feat_fr-2626_migrate_loginview_stoken_path_to_stokenloginboundary branch from fc0f377 to f062859 Compare April 22, 2026 03:53

nowgnuesLee force-pushed the 04-22-refactor_fr-2616_rely_on_react_compiler_use_memo_for_memoization branch from 19bc0b6 to 0e60f45 Compare April 22, 2026 03:53

This was referenced Apr 22, 2026

fix(FR-2627): forward api_version/date/endpoint to token_login #6893

Closed

feat(FR-2616): handle totp and concurrent-session inline in STokenLoginBoundary #6897

Merged

nowgnuesLee marked this pull request as ready for review April 23, 2026 06:09

Copilot AI review requested due to automatic review settings April 23, 2026 06:09

Copilot started reviewing on behalf of nowgnuesLee April 23, 2026 06:10 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread react/src/helper/loginSessionAuth.ts Outdated

Comment thread react/src/components/LoginView.tsx

Comment thread react/src/routes.tsx

nowgnuesLee force-pushed the 04-22-feat_fr-2626_migrate_loginview_stoken_path_to_stokenloginboundary branch from f062859 to c9bf0d6 Compare April 23, 2026 07:57

nowgnuesLee force-pushed the 04-22-refactor_fr-2616_rely_on_react_compiler_use_memo_for_memoization branch from 0e60f45 to 35db452 Compare April 23, 2026 07:57

nowgnuesLee force-pushed the 04-22-feat_fr-2626_migrate_loginview_stoken_path_to_stokenloginboundary branch from c9bf0d6 to 6c16c60 Compare April 23, 2026 08:02

nowgnuesLee force-pushed the 04-22-refactor_fr-2616_rely_on_react_compiler_use_memo_for_memoization branch from 35db452 to 3edbd01 Compare April 23, 2026 08:02

nowgnuesLee force-pushed the 04-22-feat_fr-2626_migrate_loginview_stoken_path_to_stokenloginboundary branch from 6c16c60 to c683412 Compare April 23, 2026 08:35

nowgnuesLee force-pushed the 04-22-refactor_fr-2616_rely_on_react_compiler_use_memo_for_memoization branch from 3edbd01 to 9b8a859 Compare April 23, 2026 08:35

yomybaby approved these changes Apr 23, 2026

View reviewed changes

graphite-app Bot force-pushed the 04-22-refactor_fr-2616_rely_on_react_compiler_use_memo_for_memoization branch from 9b8a859 to e109675 Compare April 23, 2026 10:36

graphite-app Bot force-pushed the 04-22-feat_fr-2626_migrate_loginview_stoken_path_to_stokenloginboundary branch from c683412 to 79e6dc4 Compare April 23, 2026 10:36

Base automatically changed from 04-22-refactor_fr-2616_rely_on_react_compiler_use_memo_for_memoization to main April 23, 2026 10:45

graphite-app Bot merged commit 79e6dc4 into main Apr 23, 2026
8 checks passed

graphite-app Bot deleted the 04-22-feat_fr-2626_migrate_loginview_stoken_path_to_stokenloginboundary branch April 23, 2026 10:46

github-pages Bot temporarily deployed to github-pages April 23, 2026 10:47 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FR-2626): migrate LoginView sToken path to STokenLoginBoundary#6861

feat(FR-2626): migrate LoginView sToken path to STokenLoginBoundary#6861
graphite-app[bot] merged 1 commit into
mainfrom
04-22-feat_fr-2626_migrate_loginview_stoken_path_to_stokenloginboundary

nowgnuesLee commented Apr 22, 2026 •

edited by atlassian Bot

Loading

Uh oh!

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yomybaby left a comment

Uh oh!

graphite-app Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nowgnuesLee commented Apr 22, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stack

Uh oh!

nowgnuesLee commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nowgnuesLee commented Apr 22, 2026 •

edited by atlassian Bot

Loading

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Coverage report for `./react`

graphite-app Bot commented Apr 23, 2026 •

edited

Loading